[ThreadNetwork] Update bindings up to Xcode 27 Beta 3#26034
Conversation
Bind the new `enableCredentialSharingModeWithExtendedPANId:completion:` selector on `THClient`, introduced in the Xcode 27 SDK. The API is available on iOS, Mac Catalyst and macOS 27.0 (ThreadNetwork is not available on tvOS). The completion handler is bound as a named delegate (`THClientEnableCredentialSharingModeCompletionHandler`) with a `[NullAllowed] NSError` parameter, matching the native `_Nullable` error, and `[Async]` generates the `Task`-based overload. This resolves the `!missing-selector!` entries in the iOS/macOS/ MacCatalyst ThreadNetwork `.todo` files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ea03367-affb-4df5-b8a6-79aa65fa9be6
There was a problem hiding this comment.
Pull request overview
Updates the ThreadNetwork bindings to match the Xcode 27 Beta 3 SDK by adding the newly introduced THClient selector for enabling credential sharing mode, and cleans up xtro annotation backlog accordingly.
Changes:
- Added
THClient.EnableCredentialSharingMode(…)with[Async]and a named completion-handler delegate. - Removed resolved
!missing-selector!xtro.todoentries for ThreadNetwork on iOS/macOS/Mac Catalyst. - Added Documentation test known-failure entries for the new API surface (method + async overload + delegate type).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/xtro-sharpie/api-annotations-dotnet/macOS-ThreadNetwork.todo | Removes resolved missing-selector todo entry (file becomes empty). |
| tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-ThreadNetwork.todo | Removes resolved missing-selector todo entry (file becomes empty). |
| tests/xtro-sharpie/api-annotations-dotnet/iOS-ThreadNetwork.todo | Removes resolved missing-selector todo entry (file becomes empty). |
| tests/cecil-tests/Documentation.KnownFailures.txt | Records documentation known-failures for the newly added ThreadNetwork API and delegate type. |
| src/threadnetwork.cs | Adds the new EnableCredentialSharingMode… binding plus a named completion-handler delegate. |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #93b1465] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 191 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Bind the new
enableCredentialSharingModeWithExtendedPANId:completion:selector onTHClient, introduced in the Xcode 27 SDK. The API is available on iOS, Mac Catalyst and macOS 27.0 (ThreadNetwork is not available on tvOS).The completion handler is bound as a named delegate (
THClientEnableCredentialSharingModeCompletionHandler) with a[NullAllowed] NSErrorparameter, matching the native_Nullableerror, and[Async]generates theTask-based overload.This resolves the
!missing-selector!entries in the iOS/macOS/ MacCatalyst ThreadNetwork.todofiles.