[src] Add ObjectiveCFrameworkAttribute to specify which Objective-C framework a type belongs to.#25039
Conversation
…ramework a type belongs to. By default a type's namespace is the Objective-C framework it belongs to, but this isn't always right (we make mistakes, Apple can move types between frameworks, etc.), so add an attribute that can specify this if it doesn't match the namespace.
There was a problem hiding this comment.
Pull request overview
Adds a new ObjCRuntime.ObjectiveCFrameworkAttribute to explicitly declare which native Objective-C framework a managed type belongs to (instead of inferring solely from the managed namespace), and wires this into the build/linker framework-gathering logic.
Changes:
- Introduce
ObjectiveCFrameworkAttributeand include it in shared sources + bgen build inputs. - Update bgen to emit
[ObjectiveCFramework ("...")]when present on types. - Update framework gathering to respect the attribute, and annotate known mis-namespaced bindings (e.g.,
NSStringDrawingContext,AVCustomRoutingControllerDelegate).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/common/Frameworks.cs | Adds attribute-aware framework detection during linking (replacing a hardcoded special-case). |
| src/frameworks.sources | Includes the new attribute source file in shared core sources. |
| src/foundation.cs | Annotates NSStringDrawingContext as belonging to UIKit for linking decisions. |
| src/bgen/bgen.csproj | Adds the new attribute file to bgen compilation inputs. |
| src/bgen/Generator.cs | Emits ObjectiveCFramework attribute during generation when present. |
| src/bgen/AttributeManager.cs | Enables reflection type lookup for the new attribute in bgen. |
| src/avrouting.cs | Uses ObjectiveCFramework to map AVCustomRoutingControllerDelegate to AVRouting under !XAMCORE_5_0. |
| src/ObjCRuntime/ObjectiveCFrameworkAttribute.cs | New attribute definition. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #8057f9a] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build #8057f9a] Build passed (Build macOS tests) ✅Pipeline on Agent |
🚀 [CI Build #8057f9a] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
✅ [PR Build #8057f9a] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
By default a type's namespace is the Objective-C framework it belongs to, but this
isn't always right (we make mistakes, Apple can move types between frameworks, etc.),
so add an attribute that can specify this if it doesn't match the namespace.