[msbuild] Enable nullability for the remaining files in this directory.#25035
Open
rolfbjarne wants to merge 1 commit intomainfrom
Open
[msbuild] Enable nullability for the remaining files in this directory.#25035rolfbjarne wants to merge 1 commit intomainfrom
rolfbjarne wants to merge 1 commit intomainfrom
Conversation
And fix any resulting issues.
Contributor
There was a problem hiding this comment.
Pull request overview
Enables nullable reference types in msbuild/Messaging/Xamarin.Messaging.Build source files and addresses resulting nullability issues/warnings in the build messaging agent/runtime.
Changes:
- Switched the remaining files from
#nullable disableto#nullable enable. - Updated API surface to reflect nullable optional parameters (
string?). - Adjusted deserialization and path-handling code to compile under nullable analysis.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| msbuild/Messaging/Xamarin.Messaging.Build/TaskRunner.cs | Enables nullable and adjusts deserialization and dotnet path/root-path logic. |
| msbuild/Messaging/Xamarin.Messaging.Build/BuildAgent.cs | Enables nullable, updates ctor optional parameters, and adjusts environment-variable setup. |
Comments suppressed due to low confidence (1)
msbuild/Messaging/Xamarin.Messaging.Build/BuildAgent.cs:74
Path.GetDirectoryName (assemblyLocation)can return null (for example whenAssembly.Locationis empty in single-file/dynamic scenarios). The null-forgiving operator would then allow a nullpathto flow intoAddValueToEnvVariable, causing runtime exceptions. Consider using a non-null source likeAppContext.BaseDirectory/ProcessPath, or add an explicit null/empty check with a clear failure mode before usingpath.
var assemblyLocation = this.GetType ().Assembly.Location;
var path = Path.GetDirectoryName (assemblyLocation)!;
AddValueToEnvVariable ("MONO_GAC_PREFIX", path);
AddValueToEnvVariable ("PATH", path);
AddValueToEnvVariable ("PKG_CONFIG_PATH", path);
Collaborator
✅ [CI Build #de978a1] Build passed (Build packages) ✅Pipeline on Agent |
Collaborator
✅ [PR Build #de978a1] Build passed (Detect API changes) ✅Pipeline on Agent |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
✅ [CI Build #de978a1] Build passed (Build macOS tests) ✅Pipeline on Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix any resulting issues.