Don't ReadyToRun-publish the proto tools on ppc64le (no crossgen2)#20007
Open
pkubaj wants to merge 1 commit into
Open
Don't ReadyToRun-publish the proto tools on ppc64le (no crossgen2)#20007pkubaj wants to merge 1 commit into
pkubaj wants to merge 1 commit into
Conversation
ppc64le has no crossgen2 backend. Disable EnablePublishReadyToRun for the proto/bootstrap tools there, mirroring the existing Mono carve-out.
Contributor
✅ No release notes required |
github-actions
Bot
added
⚠️ Affects-Bootstrap
Contributor
|
🔍 Tooling Safety Check — Affects-Bootstrap, Affects-Build-Infra
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PowerPC has no crossgen2 backend, so ReadyToRun publishing of the proto/bootstrap tools (fslex/fsyacc) fails to resolve a Microsoft.NETCore.App.Crossgen2.freebsd-ppc64le pack that does not exist.
src/fsharp/Directory.Build.propsalready disables R2R for the Mono runtime; this adds an equivalent carve-out for ppc64le. The condition uses RuntimeInformation.ProcessArchitecture == Ppc64le rather than an SDK-derived RID property, because the RID properties are not yet populated at Directory.Build.props evaluation time. Part of a FreeBSD/powerpc64le (ppc64le) port. Sibling PRs: dotnet/runtime (PAL/platform), dotnet/arcade (eng/common detection), dotnet/sdk, dotnet/fsharp.I have signed (or will sign on the dnfadmin bot's prompt) the .NET Foundation CLA.