Allow closing '>' of multiline nested type arguments to align with the opener (#15171)#20003
Open
edgarfgp wants to merge 3 commits into
Open
Allow closing '>' of multiline nested type arguments to align with the opener (#15171)#20003edgarfgp wants to merge 3 commits into
edgarfgp wants to merge 3 commits into
Conversation
…e opener (dotnet#15171) A nested multiline type-argument list whose closing '>' was aligned with the column of the opening type name was rejected with FS0010, because the '>' at the block-start column was treated as a sequence-block separator (OBLOCKSEP). A closing '>' of a type-application is a closing bracket like ')' or ']', so add it to isSeqBlockElementContinuator (scoped to GREATER true, the type-app close, leaving the '>' comparison operator unaffected).
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
Warning No PR link found in some release notes, please consider adding it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A nested, multiline type-argument list fails to parse when the inner closing
>is aligned with the column of the opening type name. Adding one extra space before the>avoids it.Fixes #15171.
Before
After
Cause
The closing
>at the same column as the enclosing sequence block's start, on a later line, was treated as a block separator (OBLOCKSEP), which broke the type-argument parse. A closing>of a type application is a closing bracket like)or], so it now belongs inisSeqBlockElementContinuatoralongsideRPAREN/RBRACK/RBRACE. Scoped toGREATER true(the type-app close), so the>comparison operator is unaffected.