[msbuild-quality] Fix MSBuild condition quoting and DotnetFsiCompilerPath typo#19990
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[msbuild-quality] Fix MSBuild condition quoting and DotnetFsiCompilerPath typo#19990github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
- Fix DotnetFsiCompilerPath condition checking wrong variable (DotnetFscCompilerPath instead of DotnetFsiCompilerPath) in Microsoft.FSharp.NetSdk.props - Quote property references in conditions per MSBuild best practices: - Microsoft.FSharp.NetSdk.targets: DisableILLinkSubstitutions, AssemblyName - Microsoft.FSharp.Targets: UsingXBuild boolean comparisons - FSharp.Profiles.props: TolerateUnusedBindings - FSharpBuild.Directory.Build.props: AdditionalFscCmdFlags Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
Area-ProjectsAndBuild
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues identified by the MSBuild file quality review.
Changes
Bug fix —
src/FSharp.Build/Microsoft.FSharp.NetSdk.propsline 79:DotnetFsiCompilerPathcondition was checkingDotnetFscCompilerPath(copy-paste error)DotnetFscCompilerPathis always set on line 75, the condition was always false, soDotnetFsiCompilerPathwas never configured in the SDK flowDotnetFsiCompilerPathinsteadCondition quoting — 4 files had unquoted property references in MSBuild conditions (violates [MSBuild best practices]((learn.microsoft.com/redacted)
src/FSharp.Build/Microsoft.FSharp.NetSdk.targets:$(DisableILLinkSubstitutions),$(AssemblyName)— shipped SDK targetsrc/FSharp.Build/Microsoft.FSharp.Targets:UsingXBuildboolean comparisons — shipped SDK targetFSharp.Profiles.props:$(TolerateUnusedBindings)FSharpBuild.Directory.Build.props:$(AdditionalFscCmdFlags)Testing
These are purely syntactic fixes (adding quotes, fixing a variable name). Full CI validation is deferred to the PR checks. No behavioral change is expected:
DotnetFsiCompilerPathfix corrects a dead-code condition to match the intended behavior