Skip to content

Debug: fix if and match condition sequence points#19932

Open
auduchinok wants to merge 8 commits into
dotnet:mainfrom
auduchinok:debug-sequencePoint-if
Open

Debug: fix if and match condition sequence points#19932
auduchinok wants to merge 8 commits into
dotnet:mainfrom
auduchinok:debug-sequencePoint-if

Conversation

@auduchinok

Copy link
Copy Markdown
Member

Continues #19897.

Fixes condition sequence point didn't include condition evaluation (i.e. f x in the examples below).
Fixes extra hidden sequence points were added at the end of the decision tree.

if f x then a else b
match f x with
| _ -> ()

Also improve sequence point baselines and adds types names to calls.

auduchinok and others added 7 commits June 8, 2026 13:15
Add `isHidden` to `DebugPointAtLeafExpr.Yes` to express it explicitly in the typed tree

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

❗ Release notes required

You can open this PR in browser to add release notes: open in github.dev


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

@github-actions github-actions Bot added ⚠️ Affects-Test-Tooling Tooling check: PR touches test framework infrastructure ⚠️ Affects-Compiler-Output Tooling check: PR touches IL emission or codegen labels Jun 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Tooling Safety Check — Affects-Compiler-Output, Affects-Test-Tooling
Affects-Compiler-Output: modifies IlxGen.fs and optimizer IL emission paths
Affects-Test-Tooling: modifies test utility Compiler.fs (baseline formatting, IL token resolution)

Generated by PR Tooling Safety Check · opus46 5.4M ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚠️ Affects-Compiler-Output Tooling check: PR touches IL emission or codegen ⚠️ Affects-Test-Tooling Tooling check: PR touches test framework infrastructure

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

1 participant