Warn and fix identity conflict when owned entity has inconsistent data in DB

[Copilot]

When a row has NULL in a non-nullable column of an outer owned entity but non-NULL values in nested inner owned entity columns, EF Core silently materializes the outer as null while still tracking the inner entity. Any subsequent SaveChanges after replacing the outer owned entity then throws a misleading InvalidOperationException about an identity conflict.

Root cause

IncludeReference only handles the case where the owner entity is non-null. When the owner is null (due to the inconsistent data), the already-tracked inner entity remains in the state manager as an orphan, causing the identity conflict later.

Changes

• IncludeReference fix (ShaperProcessingExpressionVisitor.ClientMethods.cs): Added an else if branch that detects a null owner with a non-null tracked owned entity on an ownership navigation. The caller detaches the orphaned entry (via the new QueryContext.TryGetEntry) and logs the appropriate warning.

• QueryContext.TryGetEntry(object entity) (new [EntityFrameworkInternal] method): Looks up a tracked entity by object reference in the state manager. Used by the shaper to retrieve and detach orphaned owned entities.

• CoreEventId.InconsistentOwnedDataWarning (new event, Warning level): Surfaced via CoreLoggerExtensions.InconsistentOwnedData (non-sensitive) and CoreLoggerExtensions.InconsistentOwnedDataSensitive (includes key values when sensitive data logging is enabled). Default behavior (with WarningBehavior.Throw) will throw on inconsistent data; users can configure to Log or Ignore.

• API baseline (EFCore.baseline.json): Updated for the new public members.

• Test (OwnedEntityQueryRelationalTestBase): Verifies that the warning is logged, Outer is null, and SaveChanges succeeds after replacing the owned entity with a valid instance.

// DB row: (Id=X, Outer_RequiredProperty=NULL, Outer_Inner_InnerProperty=42)
var root = await context.Set<RootEntity>().SingleAsync();
// root.Outer == null  ← was silently null before; now logs InconsistentOwnedDataWarning

root.Outer = new Outer { RequiredProperty = 1, Inner = new Inner { InnerProperty = 2 } };
await context.SaveChangesAsync(); // ← previously threw InvalidOperationException (identity conflict)

[Copilot]

Pull request overview

This PR addresses a tracking/identity-conflict edge case caused by inconsistent owned-entity data (outer owned entity materializes as null while an inner owned entity is still tracked), by detecting the condition during query materialization, detaching the orphaned owned entry, and emitting a dedicated warning.

Changes:

• Adds a new query warning (CoreEventId.InconsistentOwnedDataWarning) with sensitive/non-sensitive logging via CoreLoggerExtensions and new CoreStrings resources.
• Updates relational shaper IncludeReference to detect “null owner + tracked owned dependent” for ownership navigations, detach the orphan entry via a new QueryContext.TryGetEntry(object) helper, and log the warning.
• Adds a relational spec test reproducing the inconsistent-data scenario and verifying warning + successful SaveChanges after replacing the owned instance.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/EFCore.Tests/Diagnostics/CoreEventIdTest.cs	Updates test stubs to support logging paths that access navigation target entity type.
test/EFCore.Relational.Specification.Tests/Query/OwnedEntityQueryRelationalTestBase.cs	Adds coverage for inconsistent owned data leading to prior identity conflict on SaveChanges.
src/EFCore/Query/QueryContext.cs	Adds internal API to locate a tracked entry by entity reference for shaper use.
src/EFCore/Properties/CoreStrings.resx	Adds new localized warning messages (sensitive/non-sensitive).
src/EFCore/Properties/CoreStrings.Designer.cs	Generated event-definition accessors for the new warning messages.
src/EFCore/EFCore.baseline.json	Updates public API baseline for new event id and logger extension methods.
src/EFCore/Diagnostics/LoggingDefinitions.cs	Adds logging definition slots for the new warning messages.
src/EFCore/Diagnostics/CoreLoggerExtensions.cs	Adds logger extensions to emit the new warning (sensitive/non-sensitive).
src/EFCore/Diagnostics/CoreEventId.cs	Introduces the new event id and documentation.
src/EFCore.Relational/Query/RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.ClientMethods.cs	Implements the detaching + warning behavior during include/reference fixup when the owner is null.

Files not reviewed (1)

• src/EFCore/Properties/CoreStrings.Designer.cs: Generated file