Skip to content

Fix syntax error in API review workflow#38085

Open
AndriySvyryd wants to merge 1 commit intomainfrom
ApiWorkflowFix4
Open

Fix syntax error in API review workflow#38085
AndriySvyryd wants to merge 1 commit intomainfrom
ApiWorkflowFix4

Conversation

@AndriySvyryd
Copy link
Copy Markdown
Member

😠

@AndriySvyryd AndriySvyryd requested a review from a team as a code owner April 10, 2026 22:10
Copilot AI review requested due to automatic review settings April 10, 2026 22:10
@AndriySvyryd AndriySvyryd enabled auto-merge (squash) April 10, 2026 22:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a Python syntax error in the API review baselines GitHub Actions workflow by removing an invalid nonlocal usage in an inline Python script, while preserving the existing comment-splitting behavior for generated API diffs.

Changes:

  • Removed the nested helper using nonlocal current_body (invalid at module scope in Python) and inlined the comment-body accumulation logic.
  • Initialized and handled section explicitly per baseline file, skipping empty sections before appending to the comment body.
  • Kept the max-length splitting behavior for multi-comment posting, implemented inline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants