Additional translations for SQL Server DateTimeOffset#38076
Open
Additional translations for SQL Server DateTimeOffset#38076
Conversation
roji
force-pushed
the
roji/dto-datetime-utcdatetime-translation
branch
from
3a23d02 to
49133ed
Compare
cincuranet
reviewed
Apr 10, 2026
src/EFCore.SqlServer/Query/Internal/SqlServerSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR extends EF Core’s SQL Server query translation for temporal APIs, adding more server-side translations for DateTimeOffset members/methods and introducing a SQL Server mapping for DATETRUNC via EF.Functions.DateTrunc, along with cross-provider test updates.
Changes:
- Add SQL Server translations for
DateTimeOffsetmembers (DateTime,UtcDateTime,LocalDateTime),ToOffset(TimeSpan), andnew DateTimeOffset(DateTime[, TimeSpan]). - Add SQL Server
EF.Functions.DateTrunc(datepart, date)translations toDATETRUNCfor multiple temporal CLR types. - Add/adjust specification and provider functional tests to cover the new translations (and expected failures on non-supporting providers).
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
src/EFCore.SqlServer/Extensions/SqlServerDbFunctionsExtensions.cs |
Adds public EF.Functions.DateTrunc overloads for SQL Server. |
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMethodTranslator.cs |
Translates EF.Functions.DateTrunc to DATETRUNC. |
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMemberTranslator.cs |
Adds translations for DateTimeOffset.DateTime, UtcDateTime, LocalDateTime. |
src/EFCore.SqlServer/Query/Internal/SqlServerSqlTranslatingExpressionVisitor.cs |
Adds translations for DateTimeOffset.Offset.TotalMinutes, ToOffset(TimeSpan), and DateTimeOffset constructors. |
src/EFCore.SqlServer/Properties/SqlServerStrings.resx |
Adds new SQL Server provider error strings for new translation behaviors. |
src/EFCore.SqlServer/Properties/SqlServerStrings.Designer.cs |
Generated accessors for new SQL Server provider strings. |
src/EFCore.Relational/Query/Internal/RelationalProjectionBindingExpressionVisitor.cs |
Adjusts binding behavior to allow provider VisitNew translations in index-based mode. |
test/EFCore.Specification.Tests/Query/Translations/Temporal/DateTimeOffsetTranslationsTestBase.cs |
Adds new baseline tests for DateTimeOffset members/methods/ctors. |
test/EFCore.SqlServer.FunctionalTests/Query/Translations/Temporal/DateTimeOffsetTranslationsSqlServerTest.cs |
Adds SQL Server baselines for new DateTimeOffset translations + DateTrunc coverage. |
test/EFCore.SqlServer.FunctionalTests/Query/Translations/Temporal/DateTimeTranslationsSqlServerTest.cs |
Adds SQL Server baseline tests for DateTrunc over DateTime. |
test/EFCore.SqlServer.FunctionalTests/Query/Translations/Temporal/DateOnlyTranslationsSqlServerTest.cs |
Adds SQL Server baseline tests for DateTrunc over DateOnly. |
test/EFCore.SqlServer.FunctionalTests/Query/Translations/Temporal/TimeOnlyTranslationsSqlServerTest.cs |
Adds SQL Server baseline tests for DateTrunc over TimeOnly. |
test/EFCore.Sqlite.FunctionalTests/Query/Translations/Temporal/DateTimeOffsetTranslationsSqliteTest.cs |
Updates SQLite overrides for newly added spec tests. |
test/EFCore.Cosmos.FunctionalTests/Query/Translations/Temporal/DateTimeOffsetTranslationsCosmosTest.cs |
Updates Cosmos overrides for newly added spec tests. |
Files not reviewed (1)
- src/EFCore.SqlServer/Properties/SqlServerStrings.Designer.cs: Language not supported
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMethodTranslator.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMethodTranslator.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMemberTranslator.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMemberTranslator.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SqlServerSqlTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SqlServerSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
...e.Sqlite.FunctionalTests/Query/Translations/Temporal/DateTimeOffsetTranslationsSqliteTest.cs
Show resolved
Hide resolved
...e.Cosmos.FunctionalTests/Query/Translations/Temporal/DateTimeOffsetTranslationsCosmosTest.cs
Outdated
Show resolved
Hide resolved
roji
force-pushed
the
roji/dto-datetime-utcdatetime-translation
branch
from
49133ed to
1a8b5a1
Compare
roji
force-pushed
the
roji/dto-datetime-utcdatetime-translation
branch
from
1a8b5a1 to
ac78b86
Compare
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMethodTranslator.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMemberTranslator.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SqlServerSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
…ressionVisitor.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
...e.SqlServer.FunctionalTests/Query/Translations/Temporal/DateOnlyTranslationsSqlServerTest.cs
Show resolved
Hide resolved
...e.SqlServer.FunctionalTests/Query/Translations/Temporal/TimeOnlyTranslationsSqlServerTest.cs
Show resolved
Hide resolved
...e.SqlServer.FunctionalTests/Query/Translations/Temporal/DateTimeTranslationsSqlServerTest.cs
Show resolved
Hide resolved
...erver.FunctionalTests/Query/Translations/Temporal/DateTimeOffsetTranslationsSqlServerTest.cs
Show resolved
Hide resolved
...erver.FunctionalTests/Query/Translations/Temporal/DateTimeOffsetTranslationsSqlServerTest.cs
Outdated
Show resolved
Hide resolved
...e.Sqlite.FunctionalTests/Query/Translations/Temporal/DateTimeOffsetTranslationsSqliteTest.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMemberTranslator.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/Translators/SqlServerDateTimeMemberTranslator.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SqlServerSqlTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26781
Closes #38074
Closes #34756