Skip to content

Added exceptions that DivRem raises #12354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andanteyk wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added exceptions that DivRem raises #12354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cd4667
Added exceptions that DivRem raises
andanteyk Feb 27, 2026
845080b
fix = error (#12354)
andanteyk Feb 27, 2026
ef8a4fc
DivRem: add DivideByZeroException (#12354)
andanteyk Feb 27, 2026
75e1ecc
DivRem: add DivideByZeroException to Math (#12354)
andanteyk Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions xml/System.Numerics/BigInteger.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1716,6 +1716,8 @@ The individual bytes in the `value` array should be in little-endian order, from
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
Copy link
Contributor

@gewarren gewarren Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<paramref name="right" /> is zero.</exception>
<paramref name="right" /> is 0.</exception>

@tannergooding Wouldn't 0 be better than zero here?

Copy link
Member

@tannergooding tannergooding Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no preference. There are times where I think zero is more readable and others where I think 0 is instead.

</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down
2 changes: 2 additions & 0 deletions xml/System.Numerics/IBinaryInteger`1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,8 @@
<summary>Computes the quotient and remainder of two values.</summary>
<returns>The quotient and remainder of <paramref name="left" /> divided by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down
2 changes: 2 additions & 0 deletions xml/System/Byte.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,8 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<MemberGroup MemberName="Equals">
Expand Down
4 changes: 4 additions & 0 deletions xml/System/Int128.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,10 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
<exception cref="T:System.OverflowException">
<paramref name="left" /> is <see cref="F:System.Int128.MinValue">Int128.MinValue</see> and <paramref name="right" /> is -1.</exception>
</Docs>
</Member>
<Member MemberName="Equals">
Expand Down
2 changes: 2 additions & 0 deletions xml/System/Int16.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,8 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<MemberGroup MemberName="Equals">
Expand Down
4 changes: 4 additions & 0 deletions xml/System/Int32.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,6 +821,10 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
<exception cref="T:System.OverflowException">
<paramref name="left" /> is <see cref="F:System.Int32.MinValue">Int32.MinValue</see> and <paramref name="right" /> is -1.</exception>
</Docs>
</Member>
<MemberGroup MemberName="Equals">
Expand Down
4 changes: 4 additions & 0 deletions xml/System/Int64.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,10 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
<exception cref="T:System.OverflowException">
<paramref name="left" /> is <see cref="F:System.Int64.MinValue">Int64.MinValue</see> and <paramref name="right" /> is -1.</exception>
</Docs>
</Member>
<MemberGroup MemberName="Equals">
Expand Down
4 changes: 4 additions & 0 deletions xml/System/IntPtr.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,6 +1058,10 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
<exception cref="T:System.OverflowException">
<paramref name="left" /> is <see cref="F:System.IntPtr.MinValue">IntPtr.MinValue</see> and <paramref name="right" /> is -1.</exception>
</Docs>
</Member>
<Member MemberName="Equals">
Expand Down
28 changes: 28 additions & 0 deletions xml/System/Math.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2882,6 +2882,8 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
<summary>Produces the quotient and the remainder of two unsigned 8-bit numbers.</summary>
<returns>The quotient and the remainder of the specified numbers.</returns>
<remarks>To be added.</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down Expand Up @@ -2976,6 +2978,10 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
<summary>Produces the quotient and the remainder of two signed 32-bit numbers.</summary>
<returns>The quotient and the remainder of the specified numbers.</returns>
<remarks>To be added.</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
<exception cref="T:System.OverflowException">
<paramref name="left" /> is <see cref="F:System.Int32.MinValue">Int32.MinValue</see> and <paramref name="right" /> is -1.</exception>
</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down Expand Up @@ -3023,6 +3029,10 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
<summary>Produces the quotient and the remainder of two signed 64-bit numbers.</summary>
<returns>The quotient and the remainder of the specified numbers.</returns>
<remarks>To be added.</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
<exception cref="T:System.OverflowException">
<paramref name="left" /> is <see cref="F:System.Int64.MinValue">Int64.MinValue</see> and <paramref name="right" /> is -1.</exception>
</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down Expand Up @@ -3085,6 +3095,10 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
<summary>Produces the quotient and the remainder of two signed native-size numbers.</summary>
<returns>The quotient and the remainder of the specified numbers.</returns>
<remarks>To be added.</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
<exception cref="T:System.OverflowException">
<paramref name="left" /> is <see cref="F:System.IntPtr.MinValue">IntPtr.MinValue</see> and <paramref name="right" /> is -1.</exception>
</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down Expand Up @@ -3138,6 +3152,8 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
<summary>Produces the quotient and the remainder of two signed 8-bit numbers.</summary>
<returns>The quotient and the remainder of the specified numbers.</returns>
<remarks>To be added.</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down Expand Up @@ -3191,6 +3207,8 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
<summary>Produces the quotient and the remainder of two unsigned 16-bit numbers.</summary>
<returns>The quotient and the remainder of the specified numbers.</returns>
<remarks>To be added.</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down Expand Up @@ -3244,6 +3262,8 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
<summary>Produces the quotient and the remainder of two unsigned 32-bit numbers.</summary>
<returns>The quotient and the remainder of the specified numbers.</returns>
<remarks>To be added.</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down Expand Up @@ -3297,6 +3317,8 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
<summary>Produces the quotient and the remainder of two unsigned 64-bit numbers.</summary>
<returns>The quotient and the remainder of the specified numbers.</returns>
<remarks>To be added.</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down Expand Up @@ -3365,6 +3387,8 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
<summary>Produces the quotient and the remainder of two unsigned native-size numbers.</summary>
<returns>The quotient and the remainder of the specified numbers.</returns>
<remarks>To be added.</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<Member MemberName="DivRem">
Expand Down Expand Up @@ -3440,6 +3464,8 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="b" /> is zero.</exception>
<exception cref="T:System.OverflowException">
<paramref name="a" /> is <see cref="F:System.Int32.MinValue">Int32.MinValue</see> and <paramref name="b" /> is -1.</exception>
<altmember cref="M:System.Math.IEEERemainder(System.Double,System.Double)" />
</Docs>
</Member>
Expand Down Expand Up @@ -3516,6 +3542,8 @@ Dim i2 As Integer = CInt(Math.Ceiling(d2)) ' Result: 7969
</remarks>
<exception cref="T:System.DivideByZeroException">
<paramref name="b" /> is zero.</exception>
<exception cref="T:System.OverflowException">
<paramref name="a" /> is <see cref="F:System.Int64.MinValue">Int64.MinValue</see> and <paramref name="b" /> is -1.</exception>
<altmember cref="M:System.Math.IEEERemainder(System.Double,System.Double)" />
</Docs>
</Member>
Expand Down
2 changes: 2 additions & 0 deletions xml/System/SByte.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,8 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<MemberGroup MemberName="Equals">
Expand Down
2 changes: 2 additions & 0 deletions xml/System/UInt128.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,8 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<Member MemberName="Equals">
Expand Down
2 changes: 2 additions & 0 deletions xml/System/UInt16.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,8 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<MemberGroup MemberName="Equals">
Expand Down
2 changes: 2 additions & 0 deletions xml/System/UInt32.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,8 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<MemberGroup MemberName="Equals">
Expand Down
2 changes: 2 additions & 0 deletions xml/System/UInt64.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,8 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<MemberGroup MemberName="Equals">
Expand Down
2 changes: 2 additions & 0 deletions xml/System/UIntPtr.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,6 +925,8 @@
<returns>The quotient and remainder of <paramref name="left" /> divided-by <paramref name="right" />.</returns>
<remarks>To be added.</remarks>
<inheritdoc cref="M:System.Numerics.IBinaryInteger`1.DivRem(`0,`0)" />
<exception cref="T:System.DivideByZeroException">
<paramref name="right" /> is zero.</exception>
</Docs>
</Member>
<Member MemberName="Equals">
Expand Down