Skip to content

Update dependencies.md to reference JDK 17 instead of 11#42

Merged
jonathanpeppers merged 1 commit intodotnet:mainfrom
davidortinau:patch-1
Mar 11, 2026
Merged

Update dependencies.md to reference JDK 17 instead of 11#42
jonathanpeppers merged 1 commit intodotnet:mainfrom
davidortinau:patch-1

Conversation

@davidortinau
Copy link
Contributor

@davidortinau davidortinau commented Jul 22, 2024

I also updated the command line, so pls correct if that's wrong.


Internal previews

📄 File 🔗 Preview link
docs/android/getting-started/installation/dependencies.md docs/android/getting-started/installation/dependencies

Supersedes #42. The JDK 21 update was already applied in a prior commit.
This change uses 'latest' for cmdline-tools per jonathanpeppers' review
suggestion, so it won't go stale as new versions are released.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Android dependencies installation documentation, specifically the example sdkmanager command used for manually installing SDK components.

Changes:

  • Update the sdkmanager example to install cmdline-tools;latest instead of cmdline-tools;11.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 88 to 90
```console
sdkmanager "platforms;android-34" "platform-tools" "build-tools;34.0.0" "emulator" "system-images;android-34;default;x86_64" "cmdline-tools;11.0" --sdk_root=c:\android-sdk
sdkmanager "platforms;android-34" "platform-tools" "build-tools;34.0.0" "emulator" "system-images;android-34;default;x86_64" "cmdline-tools;latest" --sdk_root=c:\android-sdk
```
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description says this update is about referencing JDK 17 instead of 11, but the only change here switches the Android SDK package from cmdline-tools;11.0 to cmdline-tools;latest. Please align the PR metadata with the actual change (or update the doc content about the JDK version if that was the intent).

Copilot uses AI. Check for mistakes.
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was updated to 21 in main, but there is one text change we can add here.

@jonathanpeppers jonathanpeppers merged commit c535e07 into dotnet:main Mar 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants