Skip to content

Allow multiple Dev Proxy instances when asSystemProxy is false #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrytrinder merged 9 commits into from
Mar 11, 2026
Merged

Allow multiple Dev Proxy instances when asSystemProxy is false #1589

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2ff434a
Initial plan
Copilot Mar 5, 2026
5bd30d1
Allow multiple Dev Proxy instances when asSystemProxy is false
Copilot Mar 5, 2026
edf7462
Merge branch 'main' into copilot/fix-multiple-instances-issue
waldekmastykarz Mar 5, 2026
d0dcfbf
Merge branch 'main' into copilot/fix-multiple-instances-issue
waldekmastykarz Mar 5, 2026
0170b3d
Switch to per-instance state files to avoid cross-instance interference
Copilot Mar 5, 2026
c9a5f80
Clarify boolean sort order in LoadStateAsync
Copilot Mar 5, 2026
0973e28
Merge branch 'main' into copilot/fix-multiple-instances-issue
waldekmastykarz Mar 6, 2026
9a15ce9
Add PID option to logs, status, and stop commands; enhance instance m…
waldekmastykarz Mar 6, 2026
08dc3ae
Merge branch 'main' into copilot/fix-multiple-instances-issue
waldekmastykarz Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions DevProxy/Commands/DevProxyConfigOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public string? ConfigFile
}

public int? ApiPort => _parseResult?.GetValueOrDefault<int?>(DevProxyCommand.ApiPortOptionName);
public bool? AsSystemProxy => _parseResult?.GetValueOrDefault<bool?>(DevProxyCommand.AsSystemProxyOptionName);
public int? Port => _parseResult?.GetValueOrDefault<int?>(DevProxyCommand.PortOptionName);
public bool Discover => _parseResult?.GetValueOrDefault<bool?>(DevProxyCommand.DiscoverOptionName) ?? false;
public string? IPAddress => _parseResult?.GetValueOrDefault<string?>(DevProxyCommand.IpAddressOptionName);
Expand Down Expand Up @@ -138,6 +139,7 @@ public DevProxyConfigOptions()
};

var apiPortOption = new Option<int?>(DevProxyCommand.ApiPortOptionName);
var asSystemProxyOption = new Option<bool?>(DevProxyCommand.AsSystemProxyOptionName);
var portOption = new Option<int?>(DevProxyCommand.PortOptionName, "-p");

var discoverOption = new Option<bool>(DevProxyCommand.DiscoverOptionName, "--discover")
Expand All @@ -153,6 +155,7 @@ public DevProxyConfigOptions()
var options = new List<Option>
{
apiPortOption,
asSystemProxyOption,
ipAddressOption,
configFileOption,
portOption,
Expand Down
13 changes: 8 additions & 5 deletions DevProxy/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@

static async Task<int> StartDetachedProcessAsync(string[] args)
{
// Check if an instance is already running
if (await StateManager.IsInstanceRunningAsync())
// Check if an instance is already running as system proxy
var existingState = await StateManager.LoadStateAsync();
if (existingState is not null && existingState.AsSystemProxy)
{
var existingState = await StateManager.LoadStateAsync();
await Console.Error.WriteLineAsync($"Dev Proxy is already running (PID: {existingState?.Pid}).");
await Console.Error.WriteLineAsync($"Dev Proxy is already running (PID: {existingState.Pid}).");
await Console.Error.WriteLineAsync("Use 'devproxy stop' to stop it first.");
return 1;
Comment thread
waldekmastykarz marked this conversation as resolved.
}
Expand Down Expand Up @@ -206,14 +206,17 @@ static async Task<int> RunProxyAsync(string[] args, DevProxyConfigOptions option
var apiPort = options.ApiPort ?? app.Configuration.GetValue("apiPort", 8897);
var port = options.Port ?? app.Configuration.GetValue("port", 8000);

var asSystemProxy = options.AsSystemProxy ?? app.Configuration.GetValue("asSystemProxy", true);

var state = new ProxyInstanceState
{
Pid = Environment.ProcessId,
Comment thread
waldekmastykarz marked this conversation as resolved.
Outdated
ApiUrl = $"http://{(ipAddress is "0.0.0.0" or "::" ? "127.0.0.1" : ipAddress)}:{apiPort}",
LogFile = DevProxyCommand.DetachedLogFilePath,
StartedAt = DateTimeOffset.UtcNow,
ConfigFile = options.ConfigFile,
Port = port
Port = port,
AsSystemProxy = asSystemProxy
};

await StateManager.SaveStateAsync(state);
Comment thread
waldekmastykarz marked this conversation as resolved.
Outdated
Expand Down
3 changes: 3 additions & 0 deletions DevProxy/State/ProxyInstanceState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,7 @@ internal sealed class ProxyInstanceState

[JsonPropertyName("port")]
public int Port { get; set; }

[JsonPropertyName("asSystemProxy")]
public bool AsSystemProxy { get; set; } = true;
}
Loading