Skip to content

Improve Releases HttpClient resource management with response disposal #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Improve Releases HttpClient resource management with response disposal #557

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e766488
Initial plan
Copilot May 6, 2026
a981bda
Dispose HTTP request/response objects in releases utils
Copilot May 6, 2026
feef040
Adjust Utils HEAD request handling per review feedback
Copilot May 6, 2026
dfb60ec
Configure SocketsHttpHandler pooled connection lifetime
Copilot May 7, 2026
f8dbdfc
Revert SocketsHttpHandler for netstandard2.0 compatibility
Copilot May 8, 2026
74ee413
Use HttpClientHandler with explicit disposal in Utils
Copilot May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.Deployment.DotNet.Releases/src/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ internal class Utils
internal static async Task<bool> IsLatestFileAsync(string fileName, Uri address)
{
var httpRequest = new HttpRequestMessage(HttpMethod.Head, address);
HttpResponseMessage httpResponse = await s_httpClient.SendAsync(httpRequest).ConfigureAwait(false);
using HttpResponseMessage httpResponse = await s_httpClient.SendAsync(httpRequest).ConfigureAwait(false);

httpResponse.EnsureSuccessStatusCode();

Expand Down Expand Up @@ -61,7 +61,7 @@ internal static async Task DownloadFileAsync(Uri address, string fileName)
}
else
{
HttpResponseMessage httpResponse = await s_httpClient.GetAsync(address).ConfigureAwait(false);
using HttpResponseMessage httpResponse = await s_httpClient.GetAsync(address).ConfigureAwait(false);
httpResponse.EnsureSuccessStatusCode();

using FileStream stream = File.Create(fileName);
Expand Down Expand Up @@ -149,7 +149,7 @@ internal static async Task GetLatestFileAsync(string path, bool downloadLatest,

static Utils()
{
s_httpClient = new HttpClient();
s_httpClient = new HttpClient(new HttpClientHandler(), disposeHandler: true);
s_httpClient.DefaultRequestHeaders.CacheControl = new CacheControlHeaderValue
{
NoCache = true
Expand Down