[main] Source code updates from dotnet/dotnet#536
[main] Source code updates from dotnet/dotnet#536dotnet-maestro[bot] wants to merge 7 commits intomainfrom
Conversation
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk (Version 11.0.0-beta.26070.110 -> 11.0.0-beta.26167.112) [[ commit created by automation ]]
libnethost.lib in runtime is built by VS2026/v145 toolset so linking fails when we don't bump.
| :VS2022 | ||
| :: Setup vars for VS2022 | ||
| set __PlatformToolset=v143 | ||
| set __VSVersion=17 2022 |
There was a problem hiding this comment.
@akoeplinger would we not need this for VS 2022 case?
There was a problem hiding this comment.
The concern is with __PlatformToolset that is now always set to v145
There was a problem hiding this comment.
@NikolaMilosavljevic I think that's required because libnethost.lib (which is built in dotnet/runtime using VS2026) would fail to link otherwise, that was the original issue in the PR:
libnethost.lib(utils.cpp.obj) : error LNK2019: unresolved external symbol __std_find_first_not_of_trivial_pos_2 referenced in function "unsigned __int64 __cdecl std::_Find_first_not_of_pos_vectorized<wchar_t,wchar_t>(wchar_t const * const,unsigned __int64,wchar_t const * const,unsigned __int64)" (??$_Find_first_not_of_pos_vectorized@_W_W@std@@YA_KQEB_W_K01@Z) [D:\a_work\1\s\artifacts\obj\win-x64.Debug\native\projects\NetCoreCheck\EXE\NetCoreCheck.vcxproj]
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk (Version 11.0.0-beta.26167.112 -> 11.0.0-beta.26168.106) [[ commit created by automation ]]
2 participants
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch