Fix #2621 - add option action to preactions when option has a default value#2708
Merged
jonsequitur merged 4 commits intodotnet:mainfrom Apr 2, 2026
Merged
Fix #2621 - add option action to preactions when option has a default value#2708jonsequitur merged 4 commits intodotnet:mainfrom
jonsequitur merged 4 commits intodotnet:mainfrom
Conversation
jonsequitur
force-pushed
the
fix-2621
branch
3 times, most recently
from
d6ff1c6 to
bb817c6
Compare
jonsequitur
changed the title
jeffhandley
approved these changes
Apr 2, 2026
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
This seems like it has a chance of being breaking, but I think it's a reasonable risk to take on it as it's definitely intentional when the option is defined to have an associated action, defaulting to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2621. It ensures that an option with a pre-action is still invoked if it has a default value but the option is not specified on the command line.