Fix ANCM app_offline.htm notification match using QueryCCH - #68341
Open
aw0lid wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your PR, @aw0lid. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
aw0lid
force-pushed
the
fix/ancm-filewatcher
branch
2 times, most recently
from
August 11, 2026 12:03
31fe217 to
b92814b
Compare
aw0lid
force-pushed
the
fix/ancm-filewatcher
branch
from
August 11, 2026 12:26
b92814b to
c21892e
Compare
aw0lid
marked this pull request as ready for review
August 11, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ANCM app_offline.htm notification match using QueryCCH
Description
Fixes an issue in file watcher where
FILE_WATCHER::HandleChangeCompletioncompared the buffer capacity (QuerySizeCCH()) instead of the actual string length (QueryCCH()) against the notified filename length. This made the notification-drivenapp_offline.htmmatch path unreachable, causing the application to rely solely on the fallback existence check.Changes
_strFileName.QuerySizeCCH()with_strFileName.QueryCCH()infilewatcher.cpp.TEST_SetNotificationBuffer) infilewatcher.hunderANCM_TESTING.filewatcher_tests.cpp.ANCM_TESTINGinCommonLibTests.vcxproj.Fixes #68283