Use more performant span APIs#67150
Open
martincostello wants to merge 3 commits into
Open
Conversation
- Use `SearchValues` to search for invalid path characters in `EmbeddedFileProvider` and `EmbeddedFilesManifest`. - Use span-based methods in `BindingAddress` and `UrlPrefix`. Fixes dotnet#39771.
github-actions
Bot
added
the
area-networking
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @martincostello. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MihaZupan
reviewed
Jun 11, 2026
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
martincostello
commented
Jun 11, 2026
martincostello
commented
Jun 11, 2026
martincostello
commented
Jun 11, 2026
martincostello
commented
Jun 11, 2026
martincostello
commented
Jun 11, 2026
martincostello
commented
Jun 11, 2026
martincostello
commented
Jun 11, 2026
martincostello
commented
Jun 11, 2026
martincostello
commented
Jun 11, 2026
Revert overlapping changes with dotnet#67018.
MihaZupan
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use more performant span APIs
Use some new span-based APIs in some remaining call sites.
Description
Changes:
UseSearchValuesto search for invalid path characters inEmbeddedFileProviderandEmbeddedFilesManifest.BindingAddressandUrlPrefix.New analysers since 2022 have flushed out most of the possible improvements that existed at the time the issue was created, so these changes should allow the original issue to be closed off.
Fixes #39771