Skip to content

Fix Media Type Version Collation - #1223

Merged
commonsensesoftware merged 2 commits into
mainfrom
dev/css/fix-1221
Aug 22, 2026
Merged

Fix Media Type Version Collation#1223
commonsensesoftware merged 2 commits into
mainfrom
dev/css/fix-1221

Conversation

@commonsensesoftware

@commonsensesoftware commonsensesoftware commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Fix Media Type Version Collation

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

This change excludes versions by honoring media types with q=0, which explicitly requests they not be considered. It also fixes the collation of multiple versions from different media types at the same rank, which might be different.

@commonsensesoftware commonsensesoftware changed the title Fix Media Type Collation Fix Media Type Version Collation Aug 22, 2026
Comment thread src/Common/src/Common/MediaTypeQuality.cs Dismissed
Comment thread src/Common/src/Common/MediaTypeQuality.cs Fixed
Comment thread src/Common/src/Common/MediaTypeQuality.cs Fixed
Comment thread src/Common/src/Common/MediaTypeQuality.cs Fixed
Comment thread src/Common/src/Common/MediaTypeQuality.cs Dismissed
@commonsensesoftware
commonsensesoftware merged commit 1a22bb4 into main Aug 22, 2026
4 checks passed
@commonsensesoftware
commonsensesoftware deleted the dev/css/fix-1221 branch August 22, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MediaTypeApiVersionReader ranks an Accept media type with no q below one with an explicit q

2 participants