Open
Conversation
- Add publishingVersion parameter to jobs.yml template - Rename enablePublishBuildAssets to enablePublishBuildToMaestro - Forward publishingVersion to publish-build-assets.yml - Set publishingVersion: 4 in eng/build.yml - Remove DotNetPublishUsingPipelines from build args - Add manifest gathering to job.yml for V4 pipeline artifacts - Add templateContext.outputs to publish artifacts including manifests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
akoeplinger
reviewed
Mar 30, 2026
| arguments: > | ||
| -BuildId $(BARBuildId) | ||
| -PublishingInfraVersion ${{ parameters.publishingInfraVersion }} | ||
| -PublishingInfraVersion 3 |
Member
There was a problem hiding this comment.
why are we hardcoding 3 here?
Member
Author
There was a problem hiding this comment.
Because publishing is agnostic to the publishing infra version (e.g. VMR build passes 3). It just works transparently for v3/v4.
Member
Author
There was a problem hiding this comment.
I'm going to remove the parameter in another PR
Member
There was a problem hiding this comment.
should we disable this for v4 ?
Member
Author
There was a problem hiding this comment.
It's unrelated. This will pick up more than just the packages and assets if enabled. It picks up things like bin.
akoeplinger
approved these changes
Mar 30, 2026
| buildId: $(AzDOBuildId) | ||
| artifactName: PackageArtifacts | ||
| checkDownloadedFiles: true | ||
| - ${{ if eq(parameters.publishingInfraVersion, 4) }}: |
Member
There was a problem hiding this comment.
nit: you can use if/else in yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check: