[fix-finder] Localize missing NDK toolchain warning - #12481
Open
github-actions[bot] wants to merge 1 commit into
Open
[fix-finder] Localize missing NDK toolchain warning#12481github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
NdkToolsWithClangNoPlatformsemitted a hardcoded warning when an architecture-specific toolchain directory was missing, so the customer-facing message bypassed localization and had no XA code.Fix
Replace the literal in
WithClangNoPlatforms.cswith the existingProperties.Resources.XA5101_Toolchainmessage and emit it as coded warningXA5101.Validation
AndroidSdkDirectory=/tmp/gh-aw/agent/android-sdk AndroidNdkDirectory=/tmp/gh-aw/agent/android-ndk ./build.sh Prepare— passed./dotnet-local.sh build ... -m:1 --no-restore— passedGRADLE_USER_HOME=/tmp/gh-aw/agent/gradle AndroidSdkDirectory=/tmp/gh-aw/agent/android-sdk AndroidNdkDirectory=/tmp/gh-aw/agent/android-ndk ./dotnet-local.sh build src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj -m:1 --no-restore -p:BuildProjectReferences=false— passed (one pre-existing duplicate source warning)Fix-finder metadata
08-string-literal-error-messages29/30(actionability:10, safety:9, scope:10)Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
southcentralus0.in.applicationinsights.azure.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.