Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Configuration.props
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,11 @@
<XABinutilsVersion Condition="'$(XABinutilsVersion)' == ''">L_18.1.6-8.0.0-1</XABinutilsVersion>
<XABinutilsHash Condition="'$(XABinutilsHash)' == ''">5394EA6C411DA3A08BF0E6A87E1DD1B98BD2562B896C0CACD18E29E2FD4C0660</XABinutilsHash>
<!-- Microsoft OpenJDK: https://learn.microsoft.com/en-us/java/openjdk/download -->
<MicrosoftOpenJDKVersion Condition="'$(MicrosoftOpenJDKVersion)' == ''">21.0.8</MicrosoftOpenJDKVersion>
<MicrosoftOpenJDKFolder Condition="'$(MicrosoftOpenJDKFolder)' == ''">jdk-21</MicrosoftOpenJDKFolder>
<MicrosoftOpenJDKRootDirName Condition="'$(MicrosoftOpenJDKRootDirName)' == ''">jdk-21.0.8+9</MicrosoftOpenJDKRootDirName>
<MicrosoftOpenJDKVersion Condition="'$(MicrosoftOpenJDKVersion)' == ''">25.0.4.1</MicrosoftOpenJDKVersion>
<MicrosoftOpenJDKFolder Condition="'$(MicrosoftOpenJDKFolder)' == ''">jdk-25</MicrosoftOpenJDKFolder>
<MicrosoftOpenJDKRootDirName Condition="'$(MicrosoftOpenJDKRootDirName)' == ''">jdk-25.0.4.1+1</MicrosoftOpenJDKRootDirName>
<JavaSdkVersion Condition=" '$(JavaSdkVersion)' == '' ">$(MicrosoftOpenJDKVersion)</JavaSdkVersion>
<MinimumSupportedJavaSdkVersion Condition=" '$(MinimumSupportedJavaSdkVersion)' == '' ">17.0</MinimumSupportedJavaSdkVersion>
<MinimumSupportedJavaSdkVersion Condition=" '$(MinimumSupportedJavaSdkVersion)' == '' ">21.0</MinimumSupportedJavaSdkVersion>
<JavaSdkDirectory Condition=" '$(JavaSdkDirectory)' == '' ">$(AndroidToolchainDirectory)\$(MicrosoftOpenJDKFolder)</JavaSdkDirectory>
<_JdkExeExtension Condition=" '$(_JdkExeExtension)' == '' And '$(HostOS)' == 'Windows' ">.exe</_JdkExeExtension>
<JavaPath Condition=" '$(JavaPath)' == '' ">$(JavaSdkDirectory)\bin\java$(_JdkExeExtension)</JavaPath>
Expand Down
2 changes: 1 addition & 1 deletion build-tools/automation/azure-pipelines-internal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ variables:
value: 'false'
# Override for internal pipeline
- name: DefaultJavaSdkMajorVersion
value: 21
value: 25
# Override pool images for internal (non-"-open") dnceng agents.
# Confirm these pool/image names exist in the dnceng/internal project.
# Match the public pipeline's Mac image (Apple Silicon). Using the x64
Expand Down
2 changes: 1 addition & 1 deletion build-tools/automation/azure-pipelines-public.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ variables:
- template: /build-tools/automation/yaml-templates/variables.yaml@self
# Override for public pipeline
- name: DefaultJavaSdkMajorVersion
value: 21
value: 25
# Override pool images for public Microsoft-hosted agents
- name: LinuxPoolImage
value: ubuntu-22.04
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
parameters:
jdkMajorVersion: $(DefaultJavaSdkMajorVersion) # Generally 11|17|21
jdkMajorVersion: $(DefaultJavaSdkMajorVersion) # Supported: 21|25
useAgentJdkPath: true # true to use preinstalled agent JDK, false to use 'android-toolchain/jdk-NN'

steps:
Expand Down
4 changes: 2 additions & 2 deletions build-tools/automation/yaml-templates/variables.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ variables:
- name: DefaultTestSdkPlatforms # Comma-separated SDK Platform(s) to install on test agents (no spaces)
value: 35,36,36.1,37.0,37.1
- name: DefaultJavaSdkMajorVersion
value: 17
- name: LatestJavaSdkMajorVersion
value: 21
- name: LatestJavaSdkMajorVersion
value: 25
- name: ExcludedNightlyNUnitCategories
value: 'cat != SystemApplication & cat != TimeZoneInfo & cat != Localization'
- name: RunMAUITestJob
Expand Down
3 changes: 1 addition & 2 deletions eng/gradle/mirror-dependencies.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@
.EXAMPLE
pwsh ./eng/gradle/mirror-dependencies.ps1 `
-ProjectDir external/Java.Interop/tests/Xamarin.Android.Tools.Bytecode-Tests/kotlin-gradle `
-Task classes `
-GradleWrapper external/Java.Interop/build-tools/gradle/gradlew.bat
-Task classes

.EXAMPLE
pwsh ./eng/gradle/mirror-dependencies.ps1 `
Expand Down
2 changes: 1 addition & 1 deletion external/Java.Interop/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<PropertyGroup>
<DotnetToolPath Condition=" '$(DotnetToolPath)' == '' ">dotnet</DotnetToolPath>
<CmakePath Condition=" '$(CmakePath)' == '' ">cmake</CmakePath>
<GradleHome Condition=" '$(GradleHome)' == '' ">$(MSBuildThisFileDirectory)build-tools\gradle</GradleHome>
<GradleHome Condition=" '$(GradleHome)' == '' ">$(MSBuildThisFileDirectory)..\..\build-tools\gradle</GradleHome>
<GradleWPath Condition=" '$(GradleWPath)' == '' ">$(GradleHome)\gradlew</GradleWPath>
<GradleArgs Condition=" '$(GradleArgs)' == '' ">--stacktrace --no-daemon</GradleArgs>
<JavacSourceVersion Condition=" '$(JavacSourceVersion)' == '' ">11</JavacSourceVersion>
Expand Down
Binary file not shown.

This file was deleted.

172 changes: 0 additions & 172 deletions external/Java.Interop/build-tools/gradle/gradlew

This file was deleted.

84 changes: 0 additions & 84 deletions external/Java.Interop/build-tools/gradle/gradlew.bat

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ dependencies {

application {
// Define the main class for the application.
mainClassName = 'com.microsoft.android.App'
mainClass = 'com.microsoft.android.App'
}

jar {
Expand Down
5 changes: 5 additions & 0 deletions src/Xamarin.Android.Build.Tasks/Tasks/AndroidApkSigner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ protected override string GenerateCommandLineCommands ()
{
var cmd = new CommandLineBuilder ();

var javaOptions = GetJavaOptions (JavaOptions, JdkVersion);
if (!javaOptions.IsNullOrEmpty ()) {
cmd.AppendSwitch (javaOptions);
}

var manifest = AndroidAppManifest.Load (ManifestFile.ItemSpec, MonoAndroidHelper.SupportedVersions);
int? minSdk = MonoAndroidHelper.SupportedVersions.MinStableVersion?.ApiLevel;
int? maxSdk = MonoAndroidHelper.SupportedVersions.MaxStableVersion?.ApiLevel;
Expand Down
5 changes: 3 additions & 2 deletions src/Xamarin.Android.Build.Tasks/Tasks/BundleTool.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ internal virtual CommandLineBuilder GetCommandLineBuilder ()
{
var cmd = new CommandLineBuilder ();

if (!JavaOptions.IsNullOrEmpty ()) {
cmd.AppendSwitch (JavaOptions);
var javaOptions = GetJavaOptions (JavaOptions, JdkVersion);
if (!javaOptions.IsNullOrEmpty ()) {
cmd.AppendSwitch (javaOptions);
}
cmd.AppendSwitchIfNotNull ("-Xmx", JavaMaximumHeapSize);
cmd.AppendSwitchIfNotNull ("-jar ", JarPath);
Expand Down
Loading
Loading