[ci] Upgrade and automate gh-aw workflows - #12460
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the repository’s remaining gh-aw configuration to the v0.86.2 toolchain and adds a scheduled workflow that invokes the generated agentic maintenance “upgrade” operation to open an upgrade PR when allowlisted files change.
Changes:
- Updated
validate-pat-poolto use the v0.86.2 pinnedgithub/gh-aw-actions/setupSHA. - Migrated
skill-runner.mdsafe-outputsexpiressyntax from30to30dand regenerated lock metadata accordingly. - Added a weekly scheduled workflow (
agentic-auto-upgrade-pr.yml) that calls the reusableagentics-maintenance.ymlworkflow withoperation: upgrade, and refreshed theagentic-workflowsdispatcher skill references.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/validate-pat-pool.yml | Updates the gh-aw setup action pin to v0.86.2 for PAT pool validation. |
| .github/workflows/skill-runner.md | Switches deprecated expires: 30 to expires: 30d for gh-aw safe outputs behavior. |
| .github/workflows/skill-runner.lock.yml | Regenerated gh-aw lock metadata after the expires frontmatter change. |
| .github/workflows/agentic-auto-upgrade-pr.yml | Adds a scheduled/manual dispatcher to run the generated maintenance workflow’s upgrade operation. |
| .github/skills/agentic-workflows/SKILL.md | Refreshes upstream gh-aw reference list with new enclaves.md / jobs.md docs. |
f96ffd8 to
3508944
Compare
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
Four automation blockers remain in the v0.86.2 upgrade path:
- The called maintainer check accepts only
permission == admin|maintain, but GitHub reports repository maintainers aspermission: write, role_name: maintain, so normal maintainers are rejected before upgrade runs. gh aw upgrademutates workflow source/locks, but the handler stages only a non-workflow allowlist and does not report excluded changes; source codemods such asexpires: 30→30dare silently discarded and cannot be recreated by compile alone.- Every weekly run creates a timestamped branch/new fixed-title PR without searching for an existing upgrade PR, so serialized runs still duplicate open PRs.
- Manual dispatch can select a non-default ref; the reusable workflow branches from it and opens against main, including unrelated commits.
Please fix maintain-role detection, surface/handle excluded workflow migrations, deduplicate upgrade PRs, and force/guard the default branch.
The agentic workflow lock files were already generated by gh-aw v0.86.2, but the repository still contained a deprecated integer expiration and a v0.81.6 setup action pin. Apply the v0.86.2 codemod, refresh the dispatcher skill, and regenerate the affected lock metadata. Add a serialized weekly workflow that installs the latest stable gh-aw release, upgrades and validates every agentic workflow, and creates or updates one pull request containing all generated changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 761e62b9-2441-431e-8e27-f6f210dd114c
3508944 to
1711a4a
Compare
|
@dalexsoto Thanks — all four blockers were relevant. I replaced the reusable maintenance call with a default-branch-only updater that:
The workflow still keeps a non-cancelling concurrency group, and the branch remains a single commit. All three agentic workflows compile with validation and the updater passes actionlint. |
Summary
Upgrade the repository's remaining gh-aw configuration to the latest stable release, v0.86.2, and add a weekly job that installs the latest stable gh-aw release and creates or updates one upgrade pull request.
The three existing agentic workflow lock files were already generated with v0.86.2. The local CLI was upgraded from v0.84.3 before running
gh aw upgrade; newer v0.86.3/v0.87.x releases are currently prereleases and were intentionally excluded.Changes
skill-runner.mdfrom deprecatedexpires: 30syntax toexpires: 30dand regenerated its lock-file metadata.enclaves.mdandjobs.mdreferences.validate-pat-pool.ymlfrom the v0.81.6 gh-aw setup action to the v0.86.2 SHA pin.agentic-auto-upgrade-pr.yml, scheduled Mondays at 04:17 UTC.android-reviewer.lock.ymlandnightly-fix-finder.lock.ymlremained unchanged because they were already current;shared/pat_pool.mdis an imported component rather than a standalone compiled workflow.Weekly automation
The scheduled job:
copilot-pat-poolenvironment and requiresGH_AW_GITHUB_TOKENto update workflow files.gh aw upgradeand then recompiles every agentic workflow with validation..github/agents,.github/aw,.github/skills, and.github/workflows; unexpected changes outside those paths fail visibly instead of being discarded.automation/gh-aw-upgradebranch and updates its existing open PR, preventing duplicate upgrade PRs.Validation
gh aw compile .github/workflows --validate: 3 succeeded, 0 warnings*.lock.ymlfiles