Skip to content

Remove #region directives from Android.Runtime.XmlReaderPullParser#12015

Draft
jonathanpeppers with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-finder-remove-regions
Draft

Remove #region directives from Android.Runtime.XmlReaderPullParser#12015
jonathanpeppers with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-finder-remove-regions

Conversation

Copilot AI commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

XmlReaderPullParser.cs still used #region/#endregion, which conflicts with repository style (no #region). This change removes those directives while preserving section intent as inline comments.

  • Scope

    • Updated only src/Mono.Android/Android.Runtime/XmlReaderPullParser.cs.
    • No functional/API changes; this is a formatting/convention cleanup.
  • Directive cleanup

    • Converted:
      • #region IXmlResourceParser implementation// IXmlResourceParser implementation
      • #region IAttributeSet implementation// IAttributeSet implementation
      • #region IXmlPullParser implementation// IXmlPullParser implementation
    • Removed the three corresponding #endregion lines.
  • Result

    • Section labeling remains readable.
    • File no longer contains #region/#endregion.
// IXmlPullParser implementation
public void DefineEntityReplacementText (string? entityName, string? replacementText)
{
	throw new NotSupportedException ();
}

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove #region/#endregion directives from XmlReaderPullParser Remove #region directives from Android.Runtime.XmlReaderPullParser Jul 8, 2026
Copilot AI requested a review from jonathanpeppers July 8, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix-finder] Remove #region/#endregion directives from Android.Runtime.XmlReaderPullParser

2 participants