Skip to content

Use Java identity in constructor activation tests #11343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonrozsival wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −4
Open

Use Java identity in constructor activation tests #11343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaaf41e
Use Java identity in constructor activation tests
simonrozsival May 14, 2026
0973a67
Use JniEnvironment for object identity assertion
simonrozsival May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions tests/Mono.Android-Tests/Mono.Android-Tests/Java.Interop/ConstructorActivationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public void JavaSideContextConstructorForwardsArgument ()
new JValue (Application.Context))) {
Assert.AreEqual (1, ConstructorActivationContextView.ConstructorInvocations);
Assert.IsNotNull (instance.ContextValue);
Assert.AreEqual (Application.Context.Handle, instance.ContextValue.Handle);
AssertSameJavaObject (Application.Context, instance.ContextValue);
}
}

Expand All @@ -110,7 +110,7 @@ public void JavaSideContextAttributeSetConstructorForwardsArguments ()
JValue.Zero)) {
Assert.AreEqual (1, ConstructorActivationAttributeSetView.ConstructorInvocations);
Assert.IsNotNull (instance.ContextValue);
Assert.AreEqual (Application.Context.Handle, instance.ContextValue.Handle);
AssertSameJavaObject (Application.Context, instance.ContextValue);
Assert.IsNull (instance.AttributeSetValue);
}
}
Expand All @@ -127,7 +127,7 @@ public void JavaSideContextAttributeSetStyleConstructorForwardsArguments ()
new JValue (42))) {
Assert.AreEqual (1, ConstructorActivationStyledView.ConstructorInvocations);
Assert.IsNotNull (instance.ContextValue);
Assert.AreEqual (Application.Context.Handle, instance.ContextValue.Handle);
AssertSameJavaObject (Application.Context, instance.ContextValue);
Assert.IsNull (instance.AttributeSetValue);
Assert.AreEqual (42, instance.DefStyleAttrValue);
}
Expand Down Expand Up @@ -474,7 +474,7 @@ public void JavaSideObjectArrayConstructorForwardsValues ()
Assert.IsNotNull (instance.ObjectArrayValue);
Assert.AreEqual (2, instance.ObjectArrayValue.Length);
Assert.AreEqual ("object-array-value", instance.ObjectArrayValue [0].ToString ());
Assert.AreEqual (Application.Context.Handle, instance.ObjectArrayValue [1].Handle);
AssertSameJavaObject (Application.Context, instance.ObjectArrayValue [1]);
}
}

Expand Down Expand Up @@ -564,6 +564,15 @@ static void AssertRegisteredSame<T> (T instance)
registered.Dispose ();
}
}

static void AssertSameJavaObject (Java.Lang.Object expected, Java.Lang.Object actual)
{
Assert.IsNotNull (expected);
Assert.IsNotNull (actual);
Assert.IsTrue (
JniEnvironment.Types.IsSameObject (expected.PeerReference, actual.PeerReference),
$"Expected Java object identity to match. Expected handle: {expected.Handle}, actual handle: {actual.Handle}.");
}
}

[Register ("net/dot/android/test/ConstructorActivationThrowing")]
Expand Down