Skip to content

Ignore transient IO errors in on-device HTTP client handler tests #10962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 4 commits into from
Mar 18, 2026
+15 −1
Merged

Ignore transient IO errors in on-device HTTP client handler tests #10962

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ddab61
Initial plan
Copilot Mar 17, 2026
cb64eb6
Ignore transient SSL errors in on-device HTTP client handler tests
Copilot Mar 17, 2026
2e5b11e
Simplify: ignore all IOException instead of checking for specific SSL…
Copilot Mar 17, 2026
6146a05
Scope IOException check to HttpRequestException inner exceptions
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/AndroidClientHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,10 @@ protected bool IgnoreIfConnectionFailed (AggregateException aex, out bool connec
if (IgnoreIfConnectionFailed (aex.InnerException as WebException, out connectionFailed))
return true;

return IgnoreIfSocketException (aex, out connectionFailed);
if (IgnoreIfSocketException (aex, out connectionFailed))
return true;

return IgnoreIfSSLFailure (aex, out connectionFailed);
}

bool IgnoreIfConnectionFailed (HttpRequestException hrex, out bool connectionFailed)
Expand Down Expand Up @@ -168,6 +171,28 @@ bool IgnoreIfSocketException (Exception ex, out bool connectionFailed)
}
return false;
}

bool IgnoreIfSSLFailure (Exception ex, out bool connectionFailed)
{
connectionFailed = false;
// Check the exception and all inner exceptions for transient SSL errors
var current = ex;
while (current != null) {
if (current is System.IO.IOException ioEx) {
var message = ioEx.Message ?? "";
if (message.Contains ("SSL", StringComparison.OrdinalIgnoreCase) &&
(message.Contains ("BAD_DECRYPT", StringComparison.OrdinalIgnoreCase) ||
message.Contains ("DECRYPTION_FAILED", StringComparison.OrdinalIgnoreCase) ||
message.Contains ("protocol error", StringComparison.OrdinalIgnoreCase))) {
connectionFailed = true;
Assert.Ignore ($"Ignoring transient SSL error: {ioEx}");
return true;
}
}
current = current.InnerException;
}
return false;
}
Comment thread
jonathanpeppers marked this conversation as resolved.
Outdated
}

[Category ("AndroidClientHandler")]
Expand Down
Loading