Move AddKeepAlives trimmer step to standalone MSBuild task#10952
Draft
Move AddKeepAlives trimmer step to standalone MSBuild task#10952
AddKeepAlives trimmer step to standalone MSBuild task#10952Conversation
Migrate AddKeepAlivesStep out of the ILLink custom step pipeline into a standalone MSBuild task that runs AfterTargets="ILLink", following the same pattern established by StripEmbeddedLibraries in #10894. Core IL-rewriting logic is extracted into AddKeepAlivesHelper, shared by both the new task (trimmed builds) and the existing pipeline step (non-trimmed builds via LinkAssembliesNoShrink).
| { | ||
| var resolver = new DefaultAssemblyResolver (); | ||
| var cache = new TypeDefinitionCache (); | ||
| var searchDirectories = new HashSet<string> (StringComparer.OrdinalIgnoreCase); |
Member
There was a problem hiding this comment.
Is there a way we can create a new "pipeline-like" task and merge the logic here with the <StripEmbeddedLibraries/> MSBuild task? We could pick a name like <PostTrimming/> or something?
These will open/close all assemblies each time, and it would be nice if we'd just open them all once and slowly move steps into a shared MSBuild task.
Member
Author
There was a problem hiding this comment.
Yup, planning to do that! Just wanted to get it working standalone before figuring out what needs to be shared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate AddKeepAlivesStep out of the ILLink custom step pipeline into a standalone MSBuild task that runs AfterTargets="ILLink", following the same pattern established by StripEmbeddedLibraries in #10894.
Core IL-rewriting logic is extracted into AddKeepAlivesHelper, shared by both the new task (trimmed builds) and the existing pipeline step (non-trimmed builds via LinkAssembliesNoShrink).