Tests | Fix TVP query hint test timeouts against shared Azure SQL DB

[cheenamalhotra]

Problem

The sqlclient_manual_azure_* legs of sqlclient-pr have been failing intermittently with Execution Timeout Expired in TvpQueryHintsTests:

Microsoft.Data.SqlClient.SqlException : Execution Timeout Expired. The timeout period elapsed prior to
completion of the operation or the server is not responding.
   at Microsoft.Data.SqlClient.ManualTesting.Tests.TvpQueryHintsTests..ctor()

The timeouts always land on the CREATE TYPE / CREATE PROC / DROP PROC; DROP TYPE statements — never on a TVP data path.

The failures also appear across many unrelated PRs, and only ever in the Azure SQL legs.

Root cause

Two independent issues combined:

1. UserDefinedType.DropObject never dropped anything. It guarded the DROP with OBJECT_ID(...), but user-defined types live in sys.types, not sys.objects, so OBJECT_ID always returns NULL and the DROP was silently skipped. Every test run has been orphaning its table types into the target database. Locally, a single pass of the UDT-using manual tests leaked 108 types. In CI these accumulate indefinitely against a shared database, making metadata operations progressively slower — which matches the gradual onset around Aug 20.

2. TvpQueryHintsTests issued 20 DDL statements for 5 tests. Each test constructor created and dropped an identically shaped table type and stored procedure, multiplying schema-modification lock contention on a database that several platform legs hit concurrently.

Fix

• OBJECT_ID → TYPE_ID in UserDefinedType.DropObject, so types are actually dropped.
• TvpQueryHintsTests now uses an IClassFixture to create the type and procedure once per class (5x less DDL), with a 120s command timeout on the fixture connection to absorb remaining contention.

Validation

Run against SQL Server 2022:

• All 5 TvpQueryHintsTests pass.
• Broader UDT-dependent suite (DateTimeVariantTests, ConnectionSchemaTest, UdtDateTimeOffsetTest, ParametersTest, TvpQueryHintsTests): 357 passed. The 4 failures are time bulk-copy cases that fail identically on baseline main — pre-existing, in a class already tagged [Trait("Category", "flaky")].
• Leaked user-defined types after a full run: 108 → 0.

Follow-up (not in this PR)

The shared CI databases already hold a backlog of orphaned types from before this fix. Those should be purged separately, ideally during a quiet window since DROP TYPE takes a Sch-M lock.

Checklist

• Tests added or updated
• Public API changes documented (n/a — test-only change)
• Verified against customer repro (n/a — verified against CI failure signature and locally)
• Ensure no breaking changes introduced

[Copilot]

Pull request overview

This PR addresses intermittent ManualTests timeouts in the Azure SQL CI legs by reducing schema-modification (DDL) contention and ensuring transient user-defined table types are actually cleaned up after tests complete.

Changes:

• Fix UserDefinedType cleanup to correctly detect existing types using TYPE_ID() (instead of OBJECT_ID()), preventing leaked table types.
• Refactor TvpQueryHintsTests to use an IClassFixture so the table type and stored procedure are created/dropped once per class (instead of per test), and increase command timeout to tolerate shared-DB contention.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpQueryHintsTests.cs	Introduces a class fixture to reuse a single UDT + stored procedure across all tests, reducing DDL operations and timeouts.
src/Microsoft.Data.SqlClient/tests/Common/Fixtures/DatabaseObjects/UserDefinedType.cs	Fixes drop logic to correctly locate user-defined types via TYPE_ID() so they are actually removed from the shared test database.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

[cheenamalhotra]

The sqlclient_manual_azure_123_linux_net8 leg failed on an infrastructure flake unrelated to this PR — TransactionEnlistmentTest.TestManualEnlistment_Enlist hit a TCP connection timeout reaching the server (provider: TCP Provider, error: 35 / The connection attempt timed out), not an assertion failure. That test is untouched by this PR and failed the same way on build 169380 for an unrelated PR. It was 1 failure out of 871 in that leg.

Worth noting the same build confirms the fix: 13 of the 14 Azure legs passed, and every sqlclient_manual_azure_123_* leg is now free of the TvpQueryHintsTests failures that were present on builds 169380 and 169440.

/azp run sqlclient-pr