Draft
Conversation
Mark 9 intermittently failing tests as flaky so they are excluded from regular CI runs (category!=flaky) and run only in quarantine pipeline steps: - DataStreamTest.ReadStream_ReadsStreamDataCorrectly - AsyncTimeoutTest.TestDelayedAsyncTimeout - MetricsTest.ConnectionPoolGroupsCounter_Functional - ConnectionFailoverTests.NetworkError_WithUserProvidedPartner_RetryDisabled_ShouldConnectToFailoverPartner - ConnectionFailoverTests.NetworkError_WithUserProvidedPartner_RetryEnabled_ShouldConnectToFailoverPartner - ConnectionFailoverTests.TransientFault_WithUserProvidedPartner_ShouldConnectToPrimary - ConnectionRoutingTests.NetworkTimeoutAtRoutedLocation_RetryDisabled_ShouldFail - ConnectionPoolTest.BasicConnectionPoolingTest - LocalizationTest.Localization_Tests
paulmedynski
added
the
Area\Tests
Contributor
There was a problem hiding this comment.
Pull request overview
Quarantines a set of intermittently failing tests by marking them with [Trait("Category", "flaky")] so they are excluded from default CI test runs and executed only in dedicated “flaky” pipeline steps.
Changes:
- Added
Category=flakytrait to targeted unit, functional, and manual tests. - Ensures default test filters (
category!=flaky) exclude these tests from regular runs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionRoutingTests.cs | Marks the routed-location network timeout unit test as flaky. |
| src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionFailoverTests.cs | Marks three simulated failover/partner routing tests as flaky. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/MetricsTest.cs | Marks the connection pool groups metrics counter manual test as flaky. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataStreamTest/DataStreamTest.cs | Marks the stream-reading manual test as flaky. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs | Marks the basic connection pooling manual test as flaky. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/AsyncTest/AsyncTimeoutTest.cs | Marks the delayed async timeout manual test as flaky. |
| src/Microsoft.Data.SqlClient/tests/FunctionalTests/LocalizationTest.cs | Marks the localization functional test as flaky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quarantine 9 intermittently failing tests by adding
[Trait("Category", "flaky")]so they are excluded from regular CI runs and only execute in quarantine pipeline steps.Tests quarantined
DataStreamTest.ReadStream_ReadsStreamDataCorrectlytests/ManualTests/SQL/DataStreamTest/DataStreamTest.csAsyncTimeoutTest.TestDelayedAsyncTimeouttests/ManualTests/SQL/AsyncTest/AsyncTimeoutTest.csMetricsTest.ConnectionPoolGroupsCounter_Functionaltests/ManualTests/TracingTests/MetricsTest.csConnectionFailoverTests.NetworkError_..._RetryDisabled_...tests/UnitTests/SimulatedServerTests/ConnectionFailoverTests.csConnectionFailoverTests.NetworkError_..._RetryEnabled_...tests/UnitTests/SimulatedServerTests/ConnectionFailoverTests.csConnectionFailoverTests.TransientFault_..._ShouldConnectToPrimarytests/UnitTests/SimulatedServerTests/ConnectionFailoverTests.csConnectionRoutingTests.NetworkTimeoutAtRoutedLocation_..._ShouldFailtests/UnitTests/SimulatedServerTests/ConnectionRoutingTests.csConnectionPoolTest.BasicConnectionPoolingTesttests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.csLocalizationTest.Localization_Teststests/FunctionalTests/LocalizationTest.csChecklist