Conversation
paulmedynski
added
the
Area\Engineering
- Removed use of MSBuild in pipelines and documentation. - Legacy build.proj still uses it, and will be replaced shortly by build2.proj which uses the dotnet CLI exclusively.
paulmedynski
force-pushed
the
dev/paul/remove-msbuild
branch
from
0721576 to
98cb968
Compare
benrr101
left a comment
benrr101
left a comment
There was a problem hiding this comment.
In general I think this will be good - but let me know what your proposed timeline for getting this through is so I can get prepared for merge conflicts in my build2.proj work :)
|
@benrr101 - This PR will wait for your work to complete. I will deal with any conflicts here. |
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s build/test orchestration to use the dotnet CLI end-to-end (instead of invoking MSBuild directly), aligning OneBranch + CI templates and developer documentation with the upcoming build2.proj workflow.
Changes:
- Updated OneBranch pipeline steps to invoke
dotnet build/DotNetCoreCLI@2for.proj-driven builds, packing, and Roslyn analyzer runs. - Updated CI templates to use
DotNetCoreCLI@2for.projtargets and removed themsbuildagent demand where it’s no longer needed. - Updated BUILDGUIDE and internal docs/instructions to recommend
dotnet build build.proj ...and removed MSBuild-specific wording.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/onebranch/steps/roslyn-analyzers-sqlclient-step.yml | Switch Roslyn analyzer build command to dotnet build for build2.proj. |
| eng/pipelines/onebranch/steps/roslyn-analyzers-csproj-step.yml | Switch Roslyn analyzer build command to dotnet build for build.proj. |
| eng/pipelines/onebranch/steps/pack-sqlclient-step.yml | Replace MSBuild task with DotNetCoreCLI@2 build for PackMds. |
| eng/pipelines/onebranch/steps/pack-csproj-step.yml | Replace MSBuild task with DotNetCoreCLI@2 build for pack targets. |
| eng/pipelines/onebranch/steps/build-sqlclient-step.yml | Replace MSBuild task with DotNetCoreCLI@2 build for BuildMds. |
| eng/pipelines/onebranch/steps/build-csproj-step.yml | Replace MSBuild task with DotNetCoreCLI@2 build for csproj build targets. |
| eng/pipelines/common/templates/steps/run-all-tests-step.yml | Convert Windows test orchestration from MSBuild task usage to DotNetCoreCLI@2 build. |
| eng/pipelines/common/templates/steps/ci-project-build-step.yml | Convert project build steps to DotNetCoreCLI@2 build with equivalent properties. |
| eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml | Remove msbuild demand and use DotNetCoreCLI@2 for packing AKV provider. |
| doc/apps/AzureAuthentication/README.md | Remove MSBuild-specific wording for build properties. |
| BUILDGUIDE.md | Update guidance/examples to use dotnet build build.proj ... and adjust prerequisites text. |
| .github/plans/apicompat-ref-assembly-validation.md | Update example commands from dotnet msbuild to dotnet build. |
| .github/instructions/testing.instructions.md | Update testing instructions to use dotnet build build.proj ... and generalize IDE guidance. |
| .github/instructions/architecture.instructions.md | Replace “MSBuild property” wording with “build property”. |
| .github/instructions/ado-pipelines.instructions.md | Rename dotnetVerbosity description away from MSBuild-specific wording. |
| .github/copilot-instructions.md | Update repo build description to reflect dotnet build usage. |
| projects: build.proj | ||
| arguments: >- | ||
| -t:PackAkvProvider | ||
| -p:Platform=${{ parameters.platform }} |
There was a problem hiding this comment.
Platform is only preserved for build.proj. build2.proj doesn't use Platform even though it was being specified.
| inputs: | ||
| solution: build2.proj | ||
| msbuildArchitecture: x64 | ||
| platform: '${{ parameters.platform }}' |
There was a problem hiding this comment.
Here we see Platform being removed, since build2.proj doesn't use it.
| displayName: 'Create AKV Provider NuGet Package' | ||
| inputs: | ||
| solution: build.proj | ||
| msbuildArchitecture: x64 |
There was a problem hiding this comment.
msBuildArchitecture is irrelevant and has been removed everywhere.
| @@ -154,17 +154,16 @@ steps: | |||
| -p:DotnetPath=${{ parameters.dotnetx86RootPath }} | |||
There was a problem hiding this comment.
The DotnetPath decides which dotnet runtime architecture to use. msBuildArchitecture above wasn't useful here anyway.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #4168 +/- ##
==========================================
- Coverage 74.27% 66.56% -7.71%
==========================================
Files 279 274 -5
Lines 42980 65799 +22819
==========================================
+ Hits 31922 43801 +11879
- Misses 11058 21998 +10940
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Testing