Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes attribute usage by removing redundant Attribute suffixes across several SqlClient types, and includes a few whitespace-only cleanups in comments/preprocessor blocks.
Changes:
- Replaced usages like
EditorBrowsableAttribute,ResCategoryAttribute,ResDescriptionAttribute,ConditionalAttribute, and fully-qualified serialization attributes with their shortened forms. - Cleaned up trailing whitespace and spacing around
#endifand comment lines.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlParameterCollection.cs | Shortened EditorBrowsableAttribute usage; minor doc comment whitespace cleanup. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlException.cs | Shortened OptionalFieldAttribute / IgnoreDataMember usages (netfx-only) and removed stray whitespace. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependency.cs | Shortened HostProtectionAttribute, ResCategoryAttribute, ResDescriptionAttribute; whitespace cleanup. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDataReader.cs | Shortened EditorBrowsableAttribute usages. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDataAdapter.cs | Shortened ResCategoryAttribute / ResDescriptionAttribute usages. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs | Shortened ResCategoryAttribute / SettingsBindableAttribute usages; whitespace cleanup. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommandBuilder.cs | Shortened EditorBrowsableAttribute, ResCategoryAttribute, ResDescriptionAttribute usages. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/ConnectionString/DbConnectionString.netfx.cs | Shortened ConditionalAttribute usage and whitespace cleanup around #endif. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.