Official Build Cleanup 2

[benrr101]

fixes

[Copilot]

Pull request overview

This PR cleans up OneBranch/official build versioning and pipeline templates by standardizing on AssemblyBuildNumber (overflow-safe build component), simplifying template parameters, and tightening a few pipeline/script details.

Changes:

• Switch default *-dev package version fallbacks from $(BuildNumber) to $(AssemblyBuildNumber) across package version props.
• Remove the unused isPreview plumbing from OneBranch build stage/validation templates and callers.
• Minor pipeline/template cleanup (typo fix, header clarification, MSBuild property quoting, NuGet install path variable shape).

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tools/props/Versions.props	Use AssemblyBuildNumber for default SqlServer package dev version to avoid invalid/oversized version components.
src/Microsoft.Data.SqlClient/MdsVersions.props	Remove trailing whitespace line.
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/AkvProviderVersions.props	Align dev/default versioning to AssemblyBuildNumber.
src/Microsoft.Data.SqlClient.Internal/Logging/src/LoggingVersions.props	Align dev/default versioning to AssemblyBuildNumber.
src/Microsoft.Data.SqlClient.Extensions/Azure/src/AzureVersions.props	Align dev/default versioning to AssemblyBuildNumber (with one doc-block inconsistency noted).
src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/AbstractionsVersions.props	Align dev/default versioning to AssemblyBuildNumber.
eng/pipelines/onebranch/variables/package-variables.yml	Fix comment typo (“pipline” → “pipeline”).
eng/pipelines/onebranch/variables/onebranch-variables.yml	Update header comment to reflect usage by both official and non-official pipelines.
eng/pipelines/onebranch/steps/roslyn-analyzers-sqlclient-step.yml	Remove extra quoting around MSBuild -p: values.
eng/pipelines/onebranch/stages/build-stages.yml	Remove isPreview parameter and stop passing it to validation job template.
eng/pipelines/onebranch/sqlclient-official.yml	Stop passing isPreview into build-stages template.
eng/pipelines/onebranch/sqlclient-non-official.yml	Stop passing isPreview into build-stages template.
eng/pipelines/onebranch/jobs/validate-signed-package-job.yml	Remove isPreview parameter; adjust expected NuGet install folder path and tweak install-step directory listing.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.55%. Comparing base (ea6091b) to head (67302f0).
⚠️ Report is 7 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ea6091b) and HEAD (67302f0). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (ea6091b)	HEAD (67302f0)
CI-SqlClient	1	0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4155      +/-   ##
==========================================
- Coverage   74.26%   66.55%   -7.71%     
==========================================
  Files         279      274       -5     
  Lines       42980    65796   +22816     
==========================================
+ Hits        31917    43791   +11874     
- Misses      11063    22005   +10942     

Flag	Coverage Δ
CI-SqlClient	?
PR-SqlClient-Project	66.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.