Fix DynamicModel sample store isolation - #5451
Open
AndriySvyryd with Copilot wants to merge 2 commits into
Open
Conversation
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix DynamicModel sample throwing exception with EF8
Fix DynamicModel sample store isolation
Aug 19, 2026
AndriySvyryd
marked this pull request as ready for review
August 19, 2026 20:45
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a runtime failure in the DynamicModel EF Core sample (EF Core 8+) caused by sharing the same InMemory database across two incompatible model shapes. It isolates the InMemory store per model variant, aligning the provider store with the model cache key behavior already driven by UseIntProperty.
Changes:
- Derive the InMemory database name from
UseIntPropertyto prevent incompatible models from sharing the same underlying store.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DynamicModel sample throws on EF Core 8 and later because incompatible models share the same InMemory database. The sample already targets EF Core 10.
UseIntProperty.