docs: Document that ApplyConfigurationsFromAssembly requires a parameterless constructor#5366
Open
Aykuttonpc wants to merge 1 commit into
Open
Conversation
…sFromAssembly - Add a NOTE block in entity-framework/core/modeling/index.md describing the parameterless constructor requirement. - Clarify that the constructor may be public or non-public. - Mention that types without one are skipped and a SkippedEntityTypeConfigurationWarning is logged. - Point readers to ModelBuilder.ApplyConfiguration as the manual alternative. Fixes dotnet#3207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3207.
ApplyConfigurationsFromAssemblyonly instantiates configuration types that have a parameterless constructor, but this isn't currently documented. Users hit surprising behavior when theirIEntityTypeConfiguration<T>implementations have non-default constructors (e.g. for DI).This PR adds a
[!NOTE]block toentity-framework/core/modeling/index.mdnext to the existing "order is undefined" note, describing:BindingFlags.Public | BindingFlags.NonPublic+Activator.CreateInstance(type, nonPublic: true)in ModelBuilder.cs).SkippedEntityTypeConfigurationWarninglogged.ApplyConfiguration.Mirrors the style of the adjacent NOTE.