Skip to content

chore: Remove unneeded project reference from auto-generated project#3171

Open
filzrev wants to merge 1 commit into
dotnet:masterfrom
filzrev:chore-remove-unneeded-project-reference
Open

chore: Remove unneeded project reference from auto-generated project#3171
filzrev wants to merge 1 commit into
dotnet:masterfrom
filzrev:chore-remove-unneeded-project-reference

Conversation

@filzrev
Copy link
Copy Markdown
Contributor

@filzrev filzrev commented Jun 6, 2026

This PR remove ProjectReference of benchmark project from BenchmarkDotNet.Autogenerated.csproj

CsProjGenerator gather referenced dlls of benchmark project.
Then add referenced dlls as <Reference Include="..." /> node.

So original <ProjectReference Include="..." /> node is not expected to be used when building BenchmarkDotNet.Autogenerated.csproj

Test
This code path is not used when running IntegrationTest project or when using non Release custom configuration.

public async Task<BuildResult> RestoreThenBuildAsync(CancellationToken cancellationToken = default)

So I've confirmed behavior by using generated binlog.
After this PR content is merged. Reference project evaluation stage is skipped on local build.

@timcassell
Copy link
Copy Markdown
Collaborator

timcassell commented Jun 6, 2026

When I tried it originally the disassemble tests failed. Maybe that was fixed with clrmd v4. [Edit] Actually, I see the tests are still failing on arm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants