chore: Remove unneeded project reference from auto-generated project#3171
Open
filzrev wants to merge 1 commit into
Open
chore: Remove unneeded project reference from auto-generated project#3171filzrev wants to merge 1 commit into
filzrev wants to merge 1 commit into
Conversation
Collaborator
|
When I tried it originally the disassemble tests failed. Maybe that was fixed with clrmd v4. [Edit] Actually, I see the tests are still failing on arm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remove
ProjectReferenceof benchmark project fromBenchmarkDotNet.Autogenerated.csprojCsProjGenerator gather referenced dlls of benchmark project.
Then add referenced dlls as
<Reference Include="..." />node.So original
<ProjectReference Include="..." />node is not expected to be used when buildingBenchmarkDotNet.Autogenerated.csprojTest
This code path is not used when running IntegrationTest project or when using non Release custom configuration.
BenchmarkDotNet/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommand.cs
Line 57 in bcdcc98
So I've confirmed behavior by using generated
binlog.After this PR content is merged. Reference project evaluation stage is skipped on local build.