feat: Migrate CLI to use System.Commandline#3162
Open
filzrev wants to merge 4 commits into
Open
Conversation
Co-Authored-By: abdulrahman hossam <ahossam.tech@gmail.com>
filzrev
force-pushed
the
feat-migrate-system-commandline
branch
from
ad14246 to
54e0fc8
Compare
filzrev
force-pushed
the
feat-migrate-system-commandline
branch
from
54e0fc8 to
2490829
Compare
filzrev
changed the title
Member
|
I wonder if we should use this as an opportunity to consider redesigning the existing command line arguments. What we have as of today is literally two commands (run benchmarks or display info) and the benchmarking command has way too many options/arguments (I am the one to blame for that). Moreover, it certain things are impossible to configure with command line. |
filzrev
force-pushed
the
feat-migrate-system-commandline
branch
from
80da43c to
03fa8bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrate CLI library from
CommandLineParsertoSystem.CommandLine.Code changes are based on PR #3014 (by @abdulrahmanhossam)
What's changed in this PR