Skip to content

chore: Remove BenchmarkDotNet.Disassembler project#3161

Merged
timcassell merged 2 commits into
dotnet:masterfrom
filzrev:chore-remove-reference-disasembler-project
Jun 4, 2026
Merged

chore: Remove BenchmarkDotNet.Disassembler project#3161
timcassell merged 2 commits into
dotnet:masterfrom
filzrev:chore-remove-reference-disasembler-project

Conversation

@filzrev
Copy link
Copy Markdown
Contributor

@filzrev filzrev commented May 30, 2026

This PR remove BenchmarkDotNet.Disassembler project.
Because it looks like no be used after migrated to use IInProcessDiagnoser for disassembler.

@filzrev filzrev marked this pull request as ready for review May 30, 2026 19:56
@timcassell
Copy link
Copy Markdown
Collaborator

@filzrev
Copy link
Copy Markdown
Contributor Author

filzrev commented Jun 4, 2026

Need to update https://benchmarkdotnet.org/articles/contributing/disassembler.html#how-to-debug-the-disassembler

I've removed this document on latest commit.
Because How it works section seems not needed because x86/x64 disassembler is migrated to run in-process.

Currently, there are following deserializers, I thought it's not needed documented on contributing pages.

  • IntelDisassembler (x86/x64)
  • Arm64Disassembler
  • MonoDisassembler

How to debug the disassembler section also not needed.
It can debug deserializer by using --inProcess mode.

@timcassell timcassell merged commit bcdcc98 into dotnet:master Jun 4, 2026
11 checks passed
@timcassell timcassell added this to the v0.16.0 milestone Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants