Skip to content

Dynamically set the culture updates - #37530

Open
guardrex wants to merge 7 commits into
mainfrom
guardrex/glob-loc-dynamic-culture-updates
Open

Dynamically set the culture updates#37530
guardrex wants to merge 7 commits into
mainfrom
guardrex/glob-loc-dynamic-culture-updates

Conversation

@guardrex

@guardrex guardrex commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Fixes #37216

The main focus coming in was to convert the controller portions over to Minimal APIs for >=.NET 6 coverage. I also discovered several additional improvements while working on these sections.

I also noticed in passing that the Prevent open redirect attacks in ASP.NET Core article didn't mention Minimal APIs for LocalRedirect, so I added that in passing. I've added the article to the list of articles that need a bit more Blazor/Minimal API work on #34356. I'll address it later. 🏃‍♂️


Internal previews

File Preview link
aspnetcore/blazor/globalization-localization.md aspnetcore/blazor/globalization-localization
aspnetcore/security/preventing-open-redirects.md aspnetcore/security/preventing-open-redirects

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates ASP.NET Core documentation to use Minimal APIs for culture-selection redirect endpoints (where applicable) and to explicitly cover Minimal API usage of LocalRedirect for open-redirect protection.

Changes:

  • Replaced controller-based culture-setting guidance with a Minimal API endpoint for >= aspnetcore-6.0 in the Blazor globalization/localization article, with monikered guidance by hosting model/version.
  • Added Minimal API coverage for LocalRedirect to the open redirect prevention article, alongside existing MVC guidance.
  • Updated front matter metadata (ai-usage) and refreshed ms.date in touched articles.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
aspnetcore/blazor/globalization-localization.md Updates culture-selection guidance and code to use a Minimal API redirect endpoint and refreshes version-specific instructions.
aspnetcore/security/preventing-open-redirects.md Adds Minimal API example for LocalRedirect and updates metadata/date.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread aspnetcore/security/preventing-open-redirects.md Outdated
Comment thread aspnetcore/blazor/globalization-localization.md Outdated
Comment thread aspnetcore/blazor/globalization-localization.md Outdated

This comment was marked as resolved.

This comment was marked as resolved.

@guardrex
guardrex marked this pull request as ready for review August 26, 2026 13:02

This comment was marked as resolved.

@guardrex
guardrex requested a lite review from Copilot August 26, 2026 15:11
@guardrex guardrex closed this Aug 26, 2026
@guardrex guardrex reopened this Aug 26, 2026
@guardrex guardrex closed this Aug 26, 2026
@guardrex guardrex reopened this Aug 26, 2026
@guardrex
guardrex requested a review from wadepickett August 26, 2026 15:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@wadepickett wadepickett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guardrex: Approved. I couldn't find any new issues beyond what was already addressed. Looks great.

@guardrex

Copy link
Copy Markdown
Collaborator Author

Ooops! There's a small merge conflict to resolve. I'll fix it as soon as I get back to the office.

@guardrex

Copy link
Copy Markdown
Collaborator Author

@wadepickett ... Ok, that licks the merge conflict. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swap a Minimal API for the CultureController

3 participants