[typescript][typescript-resolvers] Fix enumValues not considering namingConvention in certain scenarios (2)#10657
Merged
eddeee888 merged 3 commits intomaster-nextfrom Mar 31, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: e6d2a4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/cli |
7.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/core |
6.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/add |
7.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/fragment-matcher |
7.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/introspection |
6.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/schema-ast |
6.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/time |
7.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/visitor-plugin-common |
7.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
6.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
6.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
6.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
6.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
7.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
6.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
6.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
6.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/testing |
5.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/plugin-helpers |
7.0.0-alpha-20260331125845-e6d2a4ce6d2c1f46380441d80f8a3b827fbac6d8 |
npm ↗︎ unpkg ↗︎ |
eddeee888
commented
Mar 31, 2026
Comment on lines
-944
to
-947
| ? this.convertName(this.config.enumValues[typeName].typeIdentifier, { | ||
| useTypesPrefix: false, | ||
| useTypesSuffix: false, | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
typeIdentifierConverted is the converted enum type name, so we can safely use it across callsites
eddeee888
commented
Mar 31, 2026
| namingConvention: { enumValues: 'change-case-all#constantCase' }, | ||
| enumValues: { | ||
| UserRole: './files#default as IUserRole', | ||
| UserRole: './files#default as UserRole', // NOTE: `as UserRole` doesn't do anything here, this is here to demonstrate that it's the same as './files#default' |
Collaborator
Author
There was a problem hiding this comment.
This as UserRole doesn't work at all for default imports, even on master 🤔
The fixed behaviour for default import: the name of the enum (UserRole) will have namingConvention applied (becomes IUserRole) so the subsequent references will work.
eddeee888
commented
Mar 31, 2026
Comment on lines
+688
to
+689
| expect(mergedOutputs).toContain(`C: GQL_C;`); | ||
| expect(mergedOutputs).toContain(`import { MyC as GQL_C } from '../enums.js';`); |
Collaborator
Author
There was a problem hiding this comment.
All imports and references must have naming convention applied, so subsequent refer to the enum type correctly.
10 tasks
eddeee888
added a commit
that referenced
this pull request
Apr 13, 2026
…ingConvention in certain scenarios (2) (#10657) * Ensure enumValues is consistent in typescript and typescript-resolvers * Add a note to default alias import not doing anything * Add changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the continuation of #10656. After merging said PR, I realised that the
enumValuesbehaviour needs to be applied totypescriptandtypescript-resolversas well.Related #10496
Type of change