fix(edit-content): align comment char count right and validation error left (#36629) - #36926
Open
adrianjm-dotCMS wants to merge 2 commits into
Open
fix(edit-content): align comment char count right and validation error left (#36629)#36926adrianjm-dotCMS wants to merge 2 commits into
adrianjm-dotCMS wants to merge 2 commits into
Conversation
…r left (#36629) The comment section of the new Edit Contentlet stacked the character counter and the required-message error on two separate left-aligned rows. Merge them into a single row with the error on the left and the counter on the right. The counter is pushed right with flex-1 on the validation message plus shrink-0 on the counter rather than justify-between: when the field is valid dot-field-validation-message renders no content but its host element stays in the DOM, so justify-between would drag the counter back to the left. min-h-4 with matching leading-4 keeps the row height constant, preserving the reason the previous fixed-height slot existed — activities-footer is sticky bottom-0, so a row that grows when the error mounts would shift the textarea upward. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
adrianjm-dotCMS
requested review from
KevinDavilaDotCMS,
dario-daza,
nicobytes,
oidacra,
rjvelazco and
zJaaal
August 6, 2026 20:00
adrianjm-dotCMS
marked this pull request as ready for review
August 6, 2026 20:00
dario-daza
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
{n}/500 Characterson the right. Previously they were two stacked, left-aligned rows.flex-1ondot-field-validation-message+shrink-0on the counter, notjustify-between. When the field is valid the validation message renders no content but its host element stays in the DOM, sojustify-betweenwould collapse and drag the counter back to the left.min-h-4on the row with matchingleading-4on both children keeps the row height constant. This preserves the reason the previous fixed-heighth-3.5slot existed:activities-footerissticky bottom-0, so a row that grows when the error mounts would push the textarea upward.min-w-0on the message so a long error wraps instead of squeezing the counter out of the row.Fixes #36629
Checklist
edit.content.sidebar.activities.*keysAdditional Info
Layout-only follow-up to #36372. No TypeScript or
Language.propertieschanges.Tests updated in
dot-edit-content-sidebar-activities.component.spec.ts:activities-meta-row/min-h-4instead of the removedactivities-error-slot/h-3.5, keeping the same three-state assertion (no error → error → cleared).flex-1/shrink-0pairing that pins the counter right.pnpm nx test edit-content→ 40/40 pass.pnpm nx lint edit-content→ 0 errors.Note for review: removing the separate error row shortens the sticky footer by ~26px (the
h-3.5row plus itsgap-3), so Clear/Send sit slightly higher than before. This looks like the intent of the issue, but flagging it since it is a visible side effect beyond the alignment itself.Screenshots