fix(security): obfuscate system config overrides in JVM info endpoint (#36919) - #36920
Open
wezell wants to merge 2 commits into
Open
fix(security): obfuscate system config overrides in JVM info endpoint (#36919)#36920wezell wants to merge 2 commits into
wezell wants to merge 2 commits into
Conversation
…#36919) getDBOverrides() copied SystemTable.all() into the /api/v1/jvm response unmasked, while the system-properties and environment sections already run values through obfuscateIfNeeded(). Apply the same pattern-based masking (passw|pass|passwd|secret|key|token + OBFUSCATE_SYSTEM_ENVIRONMENTAL_VARIABLES) to config overrides shown in the maintenance portlet. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3 tasks
Contributor
wezell
enabled auto-merge
August 6, 2026 21:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
One-line fix in
JVMInfoResource.getDBOverrides(): run each system-table config override through the sameobfuscateIfNeeded(key, value)used by the System Properties and Environment Variables sections, instead of copyingSystemTable.all()into the response unmasked.Before:
GET /api/v1/jvm→configOverridesreturned every override in plaintext, including keys matchingpassw|pass|passwd|secret|key|tokenthat the other two sections would have masked asa*********z.After: identical masking rules across all three sections, including the
OBFUSCATE_SYSTEM_ENVIRONMENTAL_VARIABLEScustom pattern.No behavior change for non-sensitive keys. Endpoint already requires a backend user with the maintenance portlet; this is defense-in-depth for screens that end up in screenshots and support tickets.
Checklist
🤖 Generated with Claude Code
This PR fixes: #36919