fix(publishing-queue): copy icon polish and delete-asset button consistency (#36897) - #36908
Open
hmoreras wants to merge 2 commits into
Open
fix(publishing-queue): copy icon polish and delete-asset button consistency (#36897)#36908hmoreras wants to merge 2 commits into
hmoreras wants to merge 2 commits into
Conversation
…elete terminology - Delete asset button in select-bundle dialog: compact 32x32 with 18px icon (was uneven with default PrimeNG padding and mis-sized material-symbols). - Remove asset confirmation: drop danger styling on accept, use primary. - Terminology: use "Remove" consistently for the bundle remove flow (header now "Remove bundles?", accept "Remove") and "Delete" consistently for the asset delete flow (header "Delete asset from bundle?", accept "Delete"). - Table copy-button size bump w-4/h-4 -> w-5/h-5 for parity with hover target. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
github-actions
Bot
added
the
Area : Frontend
AP2300
approved these changes
Aug 6, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 6, 2026
hmoreras
enabled auto-merge
August 6, 2026 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36897.
Summary
w-4 h-4→w-5 h-5) so the icon is comfortable to hit at standard admin zoom.material-symbols-roundedicon; before, the icon was mis-sized inside default PrimeNG small-button padding and looked oversized/misaligned.p-button-dangeron the accept button (now primary), matching the modernized dialog styling on this portlet.publishing-queue.select-bundle.remove.confirm.header= "Remove bundles?" (was reusing the generic "Delete" key) and the accept button consistently says "Remove".publishing-queue.asset-list.remove-confirm.header/.messagereworded to "Delete asset from bundle?" / "Are you sure you want to delete …", and the accept button uses a newpublishing-queue.delete= "Delete". The same.remove-confirm.*keys are shared withdot-publishing-queue-asset-list-dialog, so both dialogs get the aligned wording.Test plan
deleteicon is proportional to the row.publishing-queue.delete.confirm.header/.messageare still used by the main bundle tableDeleteflow — unchanged there.Notes
🤖 Generated with Claude Code