Sanitize page.get GraphQL variables for JSON-safe SSR responses#36208
Draft
Copilot wants to merge 3 commits into
Draft
Sanitize page.get GraphQL variables for JSON-safe SSR responses#36208Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix undefined serialization in graphql.variables for Next.js
Sanitize page.get GraphQL variables for JSON-safe SSR responses
Jun 17, 2026
rjvelazco
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Give us some information about your proposed PR
title: ''
assignees: ''
Proposed Changes
page.get()was returningundefinedoptional GraphQL variables in the response metadata, which breaks strict JSON serialization in Next.js Pages Router SSR/SSG. This update keeps the outbound GraphQL request unchanged while making returnedgraphql.variablessafe to serialize.undefinedkeys fromgraphql.variablesbefore attaching them to successfulpage.get()responses andDotErrorPage.graphqlurl,mode,languageId,fireRules,siteId) intactpersonaId,publishDate,variantName) when explicitly setgraphql.variablescontains noundefinedvalues and survives JSON round-tripChecklist
Additional Info
Returned metadata now behaves like:
No request-side behavior is intentionally changed; the fix is limited to the response/error GraphQL metadata exposed to consumers.
Screenshots