fix-vanity-url-unpublish-canonical-page#36185
Closed
riccardoruocco wants to merge 1 commit into
Closed
Conversation
riccardoruocco
force-pushed
the
fix-vanity-url-unpublish-canonical-page
branch
from
5e39c1d to
d5e9739
Compare
riccardoruocco
force-pushed
the
fix-vanity-url-unpublish-canonical-page
branch
from
d5e9739 to
93fba5b
Compare
Member
|
Closing in favor of #36205 so the checks run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes S3 static Vanity URL cleanup when the canonical page/resource is unpublished.
When
STATIC_PUSH_S3_VANITY_ALIAS_ENABLEDis enabled, unpublishing a canonical resource now looks up any generated Vanity URL aliases instatic_s3_vanity_mapping, removes the related S3 objects, and clears the mapping rows.If a vanity alias was shadowing an existing live resource at the same path, dotCMS restores that live resource on S3 instead of deleting the key.
The PR also updates the startup task number and
postgres.sqldefinition forstatic_s3_vanity_mapping, so both upgrades and fresh installs create the table correctly.