Fix: wire up owasp-suppressions.xml to dependency-check Maven plugin#35340
Open
Fix: wire up owasp-suppressions.xml to dependency-check Maven plugin#35340
Conversation
Fixes #35339 parent/pom.xml referenced dependency-check-suppressions.xml which has never existed, causing the security-check profile to run with zero suppressions since Feb 2024 (commit 62e8d60 / PR #27461). The actual suppression file is owasp-suppressions.xml at the repo root (21 documented false-positive suppressions for Elasticsearch client JARs). Correcting the filename so the plugin loads them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
Test NotesThis is a single-line configuration change in Verification requires running the actual OWASP dependency-check plugin: ```bash Expected outcome after the fix:
The change can also be verified statically: |
…parent/pom.xml
The suppression file lives at the repo root, but parent/pom.xml is one
level deeper in parent/. A bare filename resolves relative to the module
basedir (parent/), so the correct path is
\${project.basedir}/../owasp-suppressions.xml.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-located the suppression file with the pom that references it and
updated the path to \${project.basedir}/owasp-suppressions.xml so it
resolves cleanly without directory traversal.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #35339
One-line fix in
parent/pom.xml: corrects the<suppressionFile>reference from the non-existentdependency-check-suppressions.xmlto the actualowasp-suppressions.xmlthat lives at the repo root.Since commit
62e8d60061(PR #27461, Feb 2024) thesecurity-checkMaven profile has been running the OWASP dependency-check plugin with zero suppressions — causing all 21 documented Elasticsearch client false positives to appear as live CVE findings.owasp-suppressions.xmlexisted and was maintained but was never wired up.Before:
```xml
dependency-check-suppressions.xml
```
After:
```xml
owasp-suppressions.xml
```
Test plan
./mvnw dependency-check:check -P security-checkand confirm the 21 Elasticsearch client CVEs are correctly suppressed (no false-positive failures)owasp-suppressions.xmlis loaded — the plugin log should reference it at startup🤖 Generated with Claude Code