chore: Update to swift-structured-queries 0.30.0-fork.1#14
Conversation
- GRDB: Switch from doozMen fork (branch: master) to upstream groue/GRDB.swift (from: 7.9.0) - swift-sharing: Switch from branch pin to tag 2.7.4 - swift-structured-queries: Switch from branch pin to tag 0.25.2 This enables valid tagged releases of sqlite-data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Switch GRDB dependency from groue/GRDB.swift to doozMen/GRDB.swift fork with exact version 7.9.0-fork.1 for yuki-ping compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Adds @DatabaseFunction support for computed properties (fixes SyncEngine.isSynchronizing) - Updates Package.swift dependencies to use exact version 0.30.0-fork.1 - Adds missing InlineSnapshotTesting and StructuredQueriesTestSupport dependencies to SQLiteDataTestSupport - Note: Some tests fail on Swift 6.3-dev due to compiler bug (sqlite-data issue #2)
Code Review SummaryThis PR updates dependency versions and adds test dependencies. The changes look good overall with a few observations. ✅ Positive Changes
🔍 Observations
📋 Code Quality
🔒 Security & Performance
✅ RecommendationAPPROVE - This is a clean maintenance PR that improves dependency management and fixes compilation issues. The move from branch-based to version-based dependencies is a best practice. 📝 Suggestions for Future Work
🤖 Review generated by Claude Code |
There was a problem hiding this comment.
Pull request overview
This PR updates the swift-structured-queries dependency from branch-based to version 0.30.0-fork.1, fixing compilation issues with SyncEngine.isSynchronizing. It also consolidates other fork dependencies to use version tags instead of branches for better stability, and adds missing test support dependencies to the SQLiteDataTestSupport target.
Changes:
- Updated swift-structured-queries from branch to exact version 0.30.0-fork.1 (adds @DatabaseFunction support for computed properties)
- Updated GRDB.swift and swift-sharing from branch to version-based dependencies for better stability
- Added InlineSnapshotTesting and StructuredQueriesTestSupport dependencies to SQLiteDataTestSupport target
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Package.swift | Updated dependency declarations from branch references to version tags; added InlineSnapshotTesting and StructuredQueriesTestSupport to SQLiteDataTestSupport target |
| Package.resolved | Updated lock file with new version pins for GRDB.swift (7.9.0-fork.1), swift-sharing (2.7.4), and swift-structured-queries (0.30.0-fork.1); transitive dependency changes including swift-perception moving to upstream |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Impact
This fixes compilation errors in yuki-ping which depends on sqlite-data and uses SyncEngine.isSynchronizing.
Test Status
Note: Some PrimaryKeyMigrationTests fail on Swift 6.3-dev due to a known compiler bug (sqlite-data issue #2). This does not affect yuki-ping as we don't use the primary key migration feature.
Related