Skip to content

chore: Update to swift-structured-queries 0.30.0-fork.1#14

Merged
doozMen merged 3 commits intomainfrom
fix/swift-structured-queries-0.30
Feb 14, 2026
Merged

chore: Update to swift-structured-queries 0.30.0-fork.1#14
doozMen merged 3 commits intomainfrom
fix/swift-structured-queries-0.30

Conversation

@doozMen
Copy link
Owner

@doozMen doozMen commented Feb 14, 2026

Summary

  • Updates swift-structured-queries from 0.25.2 to 0.30.0-fork.1
  • Adds @DatabaseFunction support for computed properties (fixes SyncEngine.isSynchronizing compilation issue)
  • Adds missing test dependencies: InlineSnapshotTesting and StructuredQueriesTestSupport to SQLiteDataTestSupport

Impact

This fixes compilation errors in yuki-ping which depends on sqlite-data and uses SyncEngine.isSynchronizing.

Test Status

Note: Some PrimaryKeyMigrationTests fail on Swift 6.3-dev due to a known compiler bug (sqlite-data issue #2). This does not affect yuki-ping as we don't use the primary key migration feature.

Related

Stijn Willems and others added 3 commits February 14, 2026 17:34
- GRDB: Switch from doozMen fork (branch: master) to upstream groue/GRDB.swift (from: 7.9.0)
- swift-sharing: Switch from branch pin to tag 2.7.4
- swift-structured-queries: Switch from branch pin to tag 0.25.2

This enables valid tagged releases of sqlite-data.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Switch GRDB dependency from groue/GRDB.swift to doozMen/GRDB.swift
fork with exact version 7.9.0-fork.1 for yuki-ping compatibility.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Adds @DatabaseFunction support for computed properties (fixes SyncEngine.isSynchronizing)
- Updates Package.swift dependencies to use exact version 0.30.0-fork.1
- Adds missing InlineSnapshotTesting and StructuredQueriesTestSupport dependencies to SQLiteDataTestSupport
- Note: Some tests fail on Swift 6.3-dev due to compiler bug (sqlite-data issue #2)
Copilot AI review requested due to automatic review settings February 14, 2026 16:52
@doozMen doozMen merged commit 369fb0b into main Feb 14, 2026
3 of 8 checks passed
@doozMen doozMen deleted the fix/swift-structured-queries-0.30 branch February 14, 2026 16:52
@claude
Copy link

claude bot commented Feb 14, 2026

Code Review Summary

This PR updates dependency versions and adds test dependencies. The changes look good overall with a few observations.

✅ Positive Changes

  1. Better Version Pinning: Moving from branch dependencies to exact version tags improves reproducibility and stability:

    • swift-structured-queries: branch: "main"exact: "0.30.0-fork.1"
    • swift-sharing: branch: "fix/swift-623-optimizer-crash"from: "2.7.4"
    • GRDB.swift: branch: "master"exact: "7.9.0-fork.1"
  2. Test Dependencies Added: The addition of InlineSnapshotTesting and StructuredQueriesTestSupport to SQLiteDataTestSupport (Package.swift:70-71) is appropriate and addresses compilation issues.

  3. Upstream Convergence: Moving back to the official swift-perception repository (Package.resolved:97-100) instead of the fork is a positive sign of stability.

  4. Dependency Cleanup: Removal of unused swift-tagged from Package.resolved is good hygiene.

🔍 Observations

  1. Fork Dependencies: The PR still relies on forked versions of critical dependencies:

    • swift-structured-queries@0.30.0-fork.1
    • GRDB.swift@7.9.0-fork.1
    • swift-sharing@2.7.4 (from doozMen fork)

    Question: What's the timeline for upstreaming these fork changes or moving to official releases?

  2. Swift 6.3 Compiler Issues: The PR description mentions working around a known Swift 6.3-dev compiler bug (issue Swift 6.3-dev compiler crashes - workarounds applied #2). This is documented and understood, but worth tracking for future removal of workarounds.

  3. Test Failures Acknowledged: The PR description notes that PrimaryKeyMigrationTests fail on Swift 6.3-dev. Since this is documented in issue Swift 6.3-dev compiler crashes - workarounds applied #2 and doesn't affect the primary use case (yuki-ping), this is acceptable.

📋 Code Quality

  • Semantic Versioning: Using exact: for fork versions is appropriate since semantic versioning guarantees may not apply
  • Package Resolution: The originHash change in Package.resolved confirms all dependencies resolve correctly
  • No Breaking Changes: The changes are additive (test dependencies) or internal (version updates)

🔒 Security & Performance

  • No security concerns identified
  • No performance implications expected from these dependency updates
  • The new test dependencies are only used in test targets, so they don't affect production bundle size

✅ Recommendation

APPROVE - This is a clean maintenance PR that improves dependency management and fixes compilation issues. The move from branch-based to version-based dependencies is a best practice.

📝 Suggestions for Future Work

  1. Monitor upstream repositories for when fork changes can be merged back
  2. Test with newer Swift 6.3 snapshots periodically (as noted in issue Swift 6.3-dev compiler crashes - workarounds applied #2)
  3. Consider documenting the fork relationships in a DEPENDENCIES.md or similar file

🤖 Review generated by Claude Code

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the swift-structured-queries dependency from branch-based to version 0.30.0-fork.1, fixing compilation issues with SyncEngine.isSynchronizing. It also consolidates other fork dependencies to use version tags instead of branches for better stability, and adds missing test support dependencies to the SQLiteDataTestSupport target.

Changes:

  • Updated swift-structured-queries from branch to exact version 0.30.0-fork.1 (adds @DatabaseFunction support for computed properties)
  • Updated GRDB.swift and swift-sharing from branch to version-based dependencies for better stability
  • Added InlineSnapshotTesting and StructuredQueriesTestSupport dependencies to SQLiteDataTestSupport target

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
Package.swift Updated dependency declarations from branch references to version tags; added InlineSnapshotTesting and StructuredQueriesTestSupport to SQLiteDataTestSupport target
Package.resolved Updated lock file with new version pins for GRDB.swift (7.9.0-fork.1), swift-sharing (2.7.4), and swift-structured-queries (0.30.0-fork.1); transitive dependency changes including swift-perception moving to upstream

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants