Skip to content

New noinstructionscache flag #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
solewniczak wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New noinstructionscache flag #266

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6655594
New noinstructionscache flag
Apr 7, 2021
711d744
fix: don't show notice when the noinstructionscache flag is not set
solewniczak Aug 26, 2021
40dc483
Merge remote-tracking branch 'upstream/master' into feature/noinstruc…
solewniczak Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,9 @@ function get_flags($setflags) {
case 'exclude':
$flags['exclude'] = $value;
break;
case 'noinstructionscache':
$flags['noinstructionscache'] = 1;
break;
}
}
// the include_content URL parameter overrides flags
Expand Down Expand Up @@ -266,7 +269,11 @@ function _get_instructions($page, $sect, $mode, $lvl, $flags, $root_id = null, $
global $ID;
$backupID = $ID;
$ID = $page; // Change the global $ID as otherwise plugins like the discussion plugin will save data for the wrong page
$ins = p_cached_instructions(wikiFN($page), false, $page);
if ($flags['noinstructionscache']) {
Comment thread
solewniczak marked this conversation as resolved.
$ins = p_get_instructions(io_readWikiPage(wikiFN($page), $page));
} else {
$ins = p_cached_instructions(wikiFN($page), false, $page);
}
$ID = $backupID;
} else {
$ins = array();
Expand Down