feat: export the custom maintenance page#290
Merged
Merged
Conversation
The dokku-maintenance plugin exposes only a `custom-page-sha256` checksum and never the page HTML, so the content cannot be read back from the server. Export now detects that a custom page is set and emits `dokku_maintenance_custom_page` with its content lifted into the companion vars-file as a required input the user supplies before applying, mirroring how http-auth passwords are handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dokku-maintenance plugin exposes only a
custom-page-sha256checksum and never the page HTML, so the content cannot be read back from the server. Export now detects that a custom page is set and emitsdokku_maintenance_custom_pagewith its content lifted into the companion vars-file as a required input the user supplies before applying, mirroring how http-auth passwords are handled.Because the page is public HTML rather than a secret, the lifted input is required but not marked sensitive. Multi-file tarball pages collapse to the single content input, so extra assets are not captured; a faithful export awaits an upstream export command in dokku/dokku-maintenance#28.
Closes #284.