feat: reconstruct full storage_mount attachment state on export#289
Merged
josegonzalez merged 1 commit intoJul 7, 2026
Conversation
The dokku_storage_mount exporter read `storage:list --format json`, which only exposes the entry/host and container paths and is filtered to the deploy phase, so `phases`, `process_type`, `subpath`, `readonly`, and `volume_chown` were dropped and run-only mounts were missed. It now reads `storage:report --format json`, which exposes every attachment attribute for all phases, and reconstructs each field in full while omitting values that match dokku's defaults. The drift-detection read is unified onto the same report so run-only mounts are visible and the exported recipe round-trips.
josegonzalez
deleted the
281-export-reconstruct-storage-mount-phases-readonly-subpath-process-type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dokku_storage_mount exporter read
storage:list --format json, which only exposes the entry/host and container paths and is filtered to the deploy phase, sophases,process_type,subpath,readonly, andvolume_chownwere dropped and run-only mounts were missed. It now readsstorage:report --format json, which exposes every attachment attribute for all phases, and reconstructs each field in full while omitting values that match dokku's defaults. The drift-detection read is unified onto the same report so run-only mounts are visible and the exported recipe round-trips.Closes #281