Conversation
There was a problem hiding this comment.
Pull request overview
Adds OpenCode as a supported target for the existing dci skill installer flow, enabling installation into OpenCode’s expected config directory layout.
Changes:
- Add
opencodeto the supported agent list fordci skill, targeting~/.config/opencode/.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {"claude", ".claude"}, | ||
| {"codex", ".codex"}, | ||
| {"kiro", ".kiro"}, | ||
| {"gemini", ".gemini"}, | ||
| {"opencode", ".config/opencode"}, | ||
| } |
There was a problem hiding this comment.
The supported agent list is now updated to include opencode, but the test suite still hard-codes the agent list in TestInstallSkill (main_test.go) without opencode. This makes it easy for future additions to drift and leaves this new support unverified. Consider adding opencode to the test cases (and/or deriving the test list from the same source as the CLI command list) so the new install target is covered.
apgiorgi
left a comment
There was a problem hiding this comment.
Two issues to address before merging.
main_test.go — TestInstallSkill not updated: The agents slice in TestInstallSkill mirrors main.go and must be kept in sync. Add {"opencode", ".config/opencode"} to that slice (after the {"gemini", ".gemini"} entry, before the closing } at line 1079) to cover the new entry.
| {"codex", ".codex"}, | ||
| {"kiro", ".kiro"}, | ||
| {"gemini", ".gemini"}, | ||
| {"opencode", ".config/opencode"}, |
There was a problem hiding this comment.
OpenCode is the only entry using an XDG config path (.config/opencode) instead of a dotfile. Per project convention, add a brief inline comment explaining why — e.g.:
{"opencode", ".config/opencode"}, // OpenCode uses XDG config dir (~/.config), not a dotfile
Adds
dci skill opencodesubcommand, which installs the DCI skill to~/.config/opencode/skills/dci-cli/.OpenCode discovers skills by directory convention using
SKILL.mdas the entry point — consistent with Claude, Kiro, and Gemini. No agent-specific config file needed.